You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/23 15:55:37 UTC
[GitHub] [incubator-doris] qimumu9406 opened a new pull request, #9183: [Bug] Apache Doris Developer Manual - Metadata Design Documentation D…
qimumu9406 opened a new pull request, #9183:
URL: https://github.com/apache/incubator-doris/pull/9183
…escription Error
The content described in the developer manual does not match the source code
#9179
# Proposed changes
Modify the content of the developer manual
Issue Number: close #9179
## Problem Summary:Fe Leader 节点启动时，会创建并启动 leaderCheckpointer 线程（运行间隔默认六十秒）。leaderCheckpointer 会读取已存在最新的image文件和最新同步Edit log（journal_id）,对已存在最新的image进行回放，然后形成新的image并保存。之所以是重新生成一份镜像副本，而不是将已有镜像写成 image，主要是考虑写 image 加读锁期间，会阻塞写操作。所以每次 checkpoint 会占用双倍内存空间。
Describe the overview of changes.
None
## Checklist(Required)
1. Does it affect the original behavior: Yes
2. Has unit tests been added: No Need
3. Has document been added or modified: Yes
4. Does it need to update dependencies: No
5. Are there any changes that cannot be rolled back: No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9183: [Bug] Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1107832800
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9183: [Bug] Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1110509272
这个修改不准确：
leader 的checkpointer线程每60秒检查一次是否要做checkpoint，但不是每次都做。你删掉的那段话需要保留。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qimumu9406 commented on pull request #9183: [Bug] Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
qimumu9406 commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1107835947
> 我认为正确的标题是`[Improvement](Docs) ...`
I'm very sorry, so am I. So I should change the title.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qimumu9406 commented on pull request #9183: [Improvement](Docs)Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
qimumu9406 commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1110511737
> 这个不准确： 领导的检查站每一次线程修改60个检查站是否需要做检查站，但不是每次都做。你删掉那段话需要保留。
文档描述Elog达到10w触发checkpoint，这段代码我还没有找，能否告诉我是哪个类呢？谢谢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qimumu9406 commented on pull request #9183: [Improvement](Docs)Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
qimumu9406 commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1118082211
> You should also update the English document.
i think so too。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] qimumu9406 commented on pull request #9183: [Improvement](Docs)Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
qimumu9406 commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1111116568
> bdbje
非常感谢，我已经理解了。所以启动checkpoint线程必须要满足两个条件：1、editLog达到10w条 2、checkpoint执行周期为60s/次。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #9183: [Improvement](Docs)Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
morningman commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1114248989
@qimumu9406 , please rebase the master to pass the check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] jackwener commented on pull request #9183: [Bug] Apache Doris Developer Manual - Metadata Design Documentation D…
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #9183:
URL: https://github.com/apache/incubator-doris/pull/9183#issuecomment-1107831585
I think the correct title is [Improvement](Docs) ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org