You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by to...@apache.org on 2018/08/09 21:48:08 UTC
[2/9] impala git commit: Exclude files with long mangled symbols from
whitespace checks
Exclude files with long mangled symbols from whitespace checks
Change-Id: Ia99cfc9840cc0d80d2654089f7e776344831a6b2
Reviewed-on: http://gerrit.cloudera.org:8080/11169
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Tim Armstrong <ta...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/impala/repo
Commit: http://git-wip-us.apache.org/repos/asf/impala/commit/b4d20ab7
Tree: http://git-wip-us.apache.org/repos/asf/impala/tree/b4d20ab7
Diff: http://git-wip-us.apache.org/repos/asf/impala/diff/b4d20ab7
Branch: refs/heads/master
Commit: b4d20ab78071059a981d7be06726a4042c1227de
Parents: ab25d34
Author: Tim Armstrong <ta...@cloudera.com>
Authored: Wed Aug 8 12:11:34 2018 -0700
Committer: Tim Armstrong <ta...@cloudera.com>
Committed: Thu Aug 9 00:36:19 2018 +0000
----------------------------------------------------------------------
bin/jenkins/critique-gerrit-review.py | 2 ++
1 file changed, 2 insertions(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/impala/blob/b4d20ab7/bin/jenkins/critique-gerrit-review.py
----------------------------------------------------------------------
diff --git a/bin/jenkins/critique-gerrit-review.py b/bin/jenkins/critique-gerrit-review.py
index e3873ab..548eac8 100755
--- a/bin/jenkins/critique-gerrit-review.py
+++ b/bin/jenkins/critique-gerrit-review.py
@@ -66,6 +66,8 @@ EXCLUDE_FILE_PATTERNS = [
re.compile(r".*be/src/kudu.*"), # Kudu source code may have different rules.
re.compile(r".*-benchmark.cc"), # Benchmark files tend to have long lines.
re.compile(r".*/function-registry/impala_functions.py"), # Many long strings.
+ re.compile(r".*/catalog/BuiltinsDb.java"), # Many long strings.
+ re.compile(r".*/codegen/gen_ir_descriptions.py"), # Many long strings.
re.compile(r".*/shell/ext-py/*") # Third-party code.
]