You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "apalan60 (via GitHub)" <gi...@apache.org> on 2025/05/18 06:27:57 UTC

Re: [PR] MINOR: Refactor shared-group request handle methods to return CompletableFuture for consistent error handling [kafka]

apalan60 commented on code in PR #19724:
URL: https://github.com/apache/kafka/pull/19724#discussion_r2094398380


##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -135,6 +135,7 @@ class KafkaApis(val requestChannel: RequestChannel,
     }
 
     forwardingManager.forwardRequest(request, responseCallback)
+    CompletableFuture.completedFuture[Unit](())

Review Comment:
   Done. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org