[GitHub] [incubator-superset] rusackas commented on a change in pull request #10933: ESLint: Remove ts-ignore comments

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #10933:
URL: https://github.com/apache/incubator-superset/pull/10933#discussion_r491152168



##########
File path: superset-frontend/src/components/Select/SupersetStyledSelect.tsx
##########
@@ -221,8 +221,11 @@ function styled<
     // Handle onPaste event
     if (onPaste) {
       const Input = components.Input || defaultComponents.Input;
-      // @ts-ignore (needed for passing `onPaste`)
-      components.Input = props => <Input {...props} onPaste={onPaste} />;
+      components.Input = props => (
+        <div onPaste={onPaste}>
+          <Input {...props} />

Review comment:
       Not sure if there are tests around this component... have you verified by hand that this still works properly or looked for a test?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org