[GitHub] [ozone] bshashikant commented on a change in pull request #2299: HDDS-5290. Handle SIGTERM to ensure clean shutdown of SCM.

[GitBox <gi...@apache.org>]

bshashikant commented on a change in pull request #2299:
URL: https://github.com/apache/ozone/pull/2299#discussion_r644449196



##########
File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManagerStarter.java
##########
@@ -164,7 +166,15 @@ private void commonInit() {
     public void start(OzoneConfiguration conf) throws Exception {
       StorageContainerManager stm = StorageContainerManager.createSCM(conf);
       stm.start();
-      stm.join();
+
+      ShutdownHookManager.get().addShutdownHook(() -> {

Review comment:
       Yes, 1s is very short. I think it should be in minutes rather than seconds.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org