You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/08/08 20:20:00 UTC
[jira] [Commented] (HUDI-1518) Remove replaced files logic from
archival
[ https://issues.apache.org/jira/browse/HUDI-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17395615#comment-17395615 ]
ASF GitHub Bot commented on HUDI-1518:
--------------------------------------
hudi-bot edited a comment on pull request #3310:
URL: https://github.com/apache/hudi/pull/3310#issuecomment-883213429
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "a0c8bbf2ccb48e2375955d001bf1cf63f0a7097d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1041",
"triggerID" : "a0c8bbf2ccb48e2375955d001bf1cf63f0a7097d",
"triggerType" : "PUSH"
}, {
"hash" : "ac0eebe5101880e06b9cf3146bdab3c5d3ce32dc",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1044",
"triggerID" : "ac0eebe5101880e06b9cf3146bdab3c5d3ce32dc",
"triggerType" : "PUSH"
}, {
"hash" : "39fc079c1ed25a82e4667ca6c5a35467f39e2f4d",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1048",
"triggerID" : "39fc079c1ed25a82e4667ca6c5a35467f39e2f4d",
"triggerType" : "PUSH"
}, {
"hash" : "f0b369bdcadf55ee9bc58ad6bea618eee871b23f",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1059",
"triggerID" : "f0b369bdcadf55ee9bc58ad6bea618eee871b23f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* f0b369bdcadf55ee9bc58ad6bea618eee871b23f Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1059)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove replaced files logic from archival
> -----------------------------------------
>
> Key: HUDI-1518
> URL: https://issues.apache.org/jira/browse/HUDI-1518
> Project: Apache Hudi
> Issue Type: Task
> Affects Versions: 0.9.0
> Reporter: satish
> Priority: Minor
> Labels: pull-request-available
> Fix For: 0.9.0
>
>
> See https://github.com/apache/hudi/blob/79ec7b4894b997183a6e10fdc19d34f5ab4ea437/hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTimelineArchiveLog.java#L324
> Archival tries to delete replaced files in 'deleteReplacedFileGroups' method. We changed cleaner to delete replaced files. So this is no longer needed. We can instead validate that replaced files no longer exist on disk during archival.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)