You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/12 02:00:27 UTC

[GitHub] [flink] jiasheng55 opened a new pull request #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

jiasheng55 opened a new pull request #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064
 
 
   ## What is the purpose of the change
   
   This pull request makes finding SerializationSchemaFactory with ClassLoader from `Thread.currentThread().getContextClassLoader()` rather than `this.getClass().getClassLoader()`.
   
   
   ## Brief change log
   
     - Remove ClassLoader parameter when invoking `TableFactoryService#find`, so it will use `Thread.currentThread().getContextClassLoader()` as default ClassLoader.
   
   
   ## Verifying this change
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (no)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
     - The S3 file system connector: (no )
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable )
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
wuchong commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-585184335
 
 
   Thanks @jiasheng55 . 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-584988879
 
 
   <!--
   Meta data
   Hash:d803ebfd0ed066087c5330d88b9412c060740059 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148506569 TriggerType:PUSH TriggerID:d803ebfd0ed066087c5330d88b9412c060740059
   Hash:d803ebfd0ed066087c5330d88b9412c060740059 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5078 TriggerType:PUSH TriggerID:d803ebfd0ed066087c5330d88b9412c060740059
   -->
   ## CI report:
   
   * d803ebfd0ed066087c5330d88b9412c060740059 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148506569) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5078) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-584980819
 
 
   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit d803ebfd0ed066087c5330d88b9412c060740059 (Wed Feb 12 02:02:35 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] jiasheng55 commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
jiasheng55 commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-585106491
 
 
   @wuchong I verified with this PR and confirmed the issue in the JIRA had gone.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-584988879
 
 
   <!--
   Meta data
   Hash:d803ebfd0ed066087c5330d88b9412c060740059 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:d803ebfd0ed066087c5330d88b9412c060740059
   -->
   ## CI report:
   
   * d803ebfd0ed066087c5330d88b9412c060740059 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] wuchong merged pull request #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
wuchong merged pull request #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [flink] flinkbot edited a comment on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11064: [FLINK-15992][table] Fix classloader when finding TableFactory
URL: https://github.com/apache/flink/pull/11064#issuecomment-584988879
 
 
   <!--
   Meta data
   Hash:d803ebfd0ed066087c5330d88b9412c060740059 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148506569 TriggerType:PUSH TriggerID:d803ebfd0ed066087c5330d88b9412c060740059
   Hash:d803ebfd0ed066087c5330d88b9412c060740059 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5078 TriggerType:PUSH TriggerID:d803ebfd0ed066087c5330d88b9412c060740059
   -->
   ## CI report:
   
   * d803ebfd0ed066087c5330d88b9412c060740059 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148506569) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5078) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services