You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/04/10 05:39:08 UTC

[GitHub] [shardingsphere] terrymanu opened a new pull request #10021: Rename authority provider type from STORAGE to NATIVE

terrymanu opened a new pull request #10021:
URL: https://github.com/apache/shardingsphere/pull/10021


   The YAML to config authority changed to:
   
   ```yaml
   rules:
     - !AUTHORITY
       provider:
         type: STORAGE
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10021: Rename authority provider type from STORAGE to NATIVE

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #10021:
URL: https://github.com/apache/shardingsphere/pull/10021#discussion_r611002567



##########
File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/algorithm/natived/NativeAuthorityProviderAlgorithm.java
##########
@@ -48,6 +48,6 @@ public void init(final Map<String, ShardingSphereMetaData> mataDataMap, final Co
     
     @Override
     public String getType() {
-        return "STORAGE";
+        return "NATIVE";

Review comment:
       The feature is provided by SPI which is dynamic.
   Enum is static variable which user can not add new types without change original enum.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss merged pull request #10021: Rename authority provider type from STORAGE to NATIVE

Posted by GitBox <gi...@apache.org>.
menghaoranss merged pull request #10021:
URL: https://github.com/apache/shardingsphere/pull/10021


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] terrymanu commented on a change in pull request #10021: Rename authority provider type from STORAGE to NATIVE

Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #10021:
URL: https://github.com/apache/shardingsphere/pull/10021#discussion_r611002567



##########
File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/algorithm/natived/NativeAuthorityProviderAlgorithm.java
##########
@@ -48,6 +48,6 @@ public void init(final Map<String, ShardingSphereMetaData> mataDataMap, final Co
     
     @Override
     public String getType() {
-        return "STORAGE";
+        return "NATIVE";

Review comment:
       The feature is provided by SPI which is dynamic.
   Enum is static variable which user can not add new type with out change original enum.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] taojintianxia commented on a change in pull request #10021: Rename authority provider type from STORAGE to NATIVE

Posted by GitBox <gi...@apache.org>.
taojintianxia commented on a change in pull request #10021:
URL: https://github.com/apache/shardingsphere/pull/10021#discussion_r611001611



##########
File path: shardingsphere-features/shardingsphere-authority/shardingsphere-authority-common/src/main/java/org/apache/shardingsphere/authority/algorithm/natived/NativeAuthorityProviderAlgorithm.java
##########
@@ -48,6 +48,6 @@ public void init(final Map<String, ShardingSphereMetaData> mataDataMap, final Co
     
     @Override
     public String getType() {
-        return "STORAGE";
+        return "NATIVE";

Review comment:
       why not enum ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org