You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/01/21 15:26:42 UTC
[GitHub] [iotdb] jack870131 opened a new pull request #4956: [IOTDB-2430] Add example of revoke Privilege
jack870131 opened a new pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956
## Description
Issue: [[IOTDB-2430] Add example of revoke Privilege](https://issues.apache.org/jira/browse/IOTDB-2430?jql=project%20%3D%20IOTDB%20AND%20resolution%20%3D%20Unresolved%20AND%20labels%20in%20(easy-fix%2C%20easy-fixed%2C%20EasyFix%2C%20easyfix%2C%20easytest%2C%20easytask%2C%20easytext)%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC)
I actually not sure if I should add single or double quote string literals for the privilege names (e.g. revoke user sgcc_write_user privileges 'INSERT_TIMESERIES' on root.sgcc).
I did see the string literals for INSERT_TIMESERIES in the documents of the previous versions, but I didn't see the string literals in the latest version, which I think is weird. So I just left it the same as the current version.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [x] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [ ] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu merged pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
SteveYurongSu merged pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#discussion_r791386371
##########
File path: docs/zh/UserGuide/Administration-Management/Administration.md
##########
@@ -113,6 +113,27 @@ IoTDB> INSERT INTO root.ln.wf01.wt01(timestamp, status) values(1509465600000, tr
Msg: The statement is executed successfully.
```
+### 撤销用户权限
+
+授予用戶權限後，我們可以使用 `REVOKE USER <userName> PRIVILEGES <privileges> ON <nodeName>` 來撤銷已授予的用戶權限。 例如：
Review comment:
Should we use the simplified Chinese here to keep the consistency. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] SteveYurongSu commented on pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
SteveYurongSu commented on pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#issuecomment-1019328336
Hi @jack870131, nice to see you back!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tsunghanjacktsai commented on a change in pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on a change in pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#discussion_r791770753
##########
File path: docs/zh/UserGuide/Administration-Management/Administration.md
##########
@@ -113,6 +113,27 @@ IoTDB> INSERT INTO root.ln.wf01.wt01(timestamp, status) values(1509465600000, tr
Msg: The statement is executed successfully.
```
+### 撤销用户权限
+
+授予用戶權限後，我們可以使用 `REVOKE USER <userName> PRIVILEGES <privileges> ON <nodeName>` 來撤銷已授予的用戶權限。 例如：
Review comment:
Oh, sorry for this. I'll correct it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] jack870131 commented on pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
jack870131 commented on pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#issuecomment-1019405658
> Hi @jack870131, nice to see you back!
Hey, sorry for going without contributions for an year. Nice to see the community again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] tsunghanjacktsai commented on a change in pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
tsunghanjacktsai commented on a change in pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#discussion_r791770753
##########
File path: docs/zh/UserGuide/Administration-Management/Administration.md
##########
@@ -113,6 +113,27 @@ IoTDB> INSERT INTO root.ln.wf01.wt01(timestamp, status) values(1509465600000, tr
Msg: The statement is executed successfully.
```
+### 撤销用户权限
+
+授予用戶權限後，我們可以使用 `REVOKE USER <userName> PRIVILEGES <privileges> ON <nodeName>` 來撤銷已授予的用戶權限。 例如：
Review comment:
Oh, sorry for this. I'll correct it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] HTHou commented on a change in pull request #4956: [IOTDB-2430] Add example of revoke Privilege
Posted by GitBox <gi...@apache.org>.
HTHou commented on a change in pull request #4956:
URL: https://github.com/apache/iotdb/pull/4956#discussion_r791386371
##########
File path: docs/zh/UserGuide/Administration-Management/Administration.md
##########
@@ -113,6 +113,27 @@ IoTDB> INSERT INTO root.ln.wf01.wt01(timestamp, status) values(1509465600000, tr
Msg: The statement is executed successfully.
```
+### 撤销用户权限
+
+授予用戶權限後，我們可以使用 `REVOKE USER <userName> PRIVILEGES <privileges> ON <nodeName>` 來撤銷已授予的用戶權限。 例如：
Review comment:
Should we use the simplified Chinese here to keep the consistency. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org