You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Matteo Bertozzi (JIRA)" <ji...@apache.org> on 2016/01/08 20:41:39 UTC

[jira] [Updated] (HBASE-15052) Use EnvironmentEdgeManager in ReplicationSource

     [ https://issues.apache.org/jira/browse/HBASE-15052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matteo Bertozzi updated HBASE-15052:
------------------------------------
    Attachment: HBASE-15052-v0.patch

> Use EnvironmentEdgeManager in ReplicationSource 
> ------------------------------------------------
>
>                 Key: HBASE-15052
>                 URL: https://issues.apache.org/jira/browse/HBASE-15052
>             Project: HBase
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 2.0.0, 1.2.0, 1.1.2, 1.0.3, 0.98.16.1
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Trivial
>         Attachments: HBASE-15052-v0.patch, HBASE-15052-v0.patch
>
>
> ReplicationSource is passing System.currentTimeMillis() to MetricsSource.setAgeOfLastShippedOp() which is subtracting that from EnvironmentEdgeManager.currentTime().
> {code}
> // if there was nothing to ship and it's not an error
> // set "ageOfLastShippedOp" to <now> to indicate that we're current
> metrics.setAgeOfLastShippedOp(System.currentTimeMillis(), walGroupId);
> public void setAgeOfLastShippedOp(long timestamp, String walGroup) {
>     long age = EnvironmentEdgeManager.currentTime() - timestamp;
> {code}
>  we should just use EnvironmentEdgeManager.currentTime() in ReplicationSource



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)