[GitHub] azai91 commented on a change in pull request #12166: Module predict API can accept NDArray as input

[GitBox <gi...@apache.org>]

azai91 commented on a change in pull request #12166: Module predict API can accept NDArray as input
URL: https://github.com/apache/incubator-mxnet/pull/12166#discussion_r210163595
 
 

 ##########
 File path: python/mxnet/module/base_module.py
 ##########
 @@ -333,7 +334,7 @@ def predict(self, eval_data, num_batch=None, merge_batches=True, reset=True,
 
         Parameters
         ----------
-        eval_data : DataIter
+        eval_data : DataIter or NDArray or ndarray
 
 Review comment:
   yes, the current API makes it difficult for a developer to get a model up and running. given a `predict` API, I think it is reasonable for most developers to assume that it would accept a ndarray of some sort. Also our documentation currently for the API is not too instructive: https://mxnet.apache.org/api/python/module/module.html (the example on the top of the page says that it accepts a nd_iter). if you go to the documetation for predict it links to the DataIter class (https://mxnet.apache.org/api/python/io/io.html#mxnet.io.DataIter) without showing how to use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services