You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/12/21 11:22:16 UTC
[GitHub] [cloudstack-primate] davidjumani opened a new pull request #903: Allowing user to use browser timezone
davidjumani opened a new pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-750238520
Checked - lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749959551
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-748938922
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749484289
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-748939266
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749959961
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-750250798
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3775)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] DaanHoogland commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749560419
out of interest @davidjumani ; are we looking at a 13:30 timezone difference in your example?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-748942948
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3759)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#discussion_r547725003
##########
File path: src/locales/en.json
##########
@@ -2155,6 +2155,7 @@
"label.usageinterface": "Usage Interface",
"label.usagename": "Usage Type",
"label.usageunit": "Unit",
+"label.use.system.timezone": "Use System Timezone",
Review comment:
As I said that was just nit-picking. This is actually more misleading (which system?), the previous one made more sense (I think most users may prefer Computer timezone or local timezone... consult with others?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749966226
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749484822
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749591462
@DaanHoogland yes, the admin's timezone is set to PST while my local time is in IST
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749970392
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3774)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749489051
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3769)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749966384
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] davidjumani commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
davidjumani commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-750230049
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749958009
@davidjumani nit - should it say local or computer timezone?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-750231010
@davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #903: Allowing user to use browser timezone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #903:
URL: https://github.com/apache/cloudstack-primate/pull/903#issuecomment-749963681
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/903 (JID-3773)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org