[GitHub] [pinot] kishoreg commented on a diff in pull request #8382: Annotate all builtin scalar functions to handle NULL (avoid throwing NullPointerException) when input value is null

[GitBox <gi...@apache.org>]

kishoreg commented on code in PR #8382:
URL: https://github.com/apache/pinot/pull/8382#discussion_r909197339


##########
pinot-spi/src/main/java/org/apache/pinot/spi/annotations/ScalarFunction.java:
##########
@@ -49,4 +49,7 @@
   // If empty, FunctionsRegistry registers the method name as function name;
   // If not empty, FunctionsRegistry only registers the function names specified here, the method name is ignored.
   String[] names() default {};
+
+  // Whether the scalar function expects and can handle null arguments.
+  boolean nullableParameters() default false;

Review Comment:
   rename to allowNullParameters since it's a boolean.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org