You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2017/08/14 15:16:29 UTC

[GitHub] flink issue #4532: [FLINK-7337] [table] Refactor internal handling of time i...

Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/4532
  
    @wuchong @fhueske I hope I addressed all code related issues. Is it ok to merge this for now? I will create a follow up issue for the Table to DataStream/TableSink conversion case.
    
    > whether we should change the rowtime type when it is an existing field
    I think this is a very special case. But it is just a nice addition to make the user's life easier. We could also remove the replacing feature as a whole to avoid confusion due to the data type conversion. In general, we should get rid of `TIMESTAMP` and work on longs as much as possible. In the near future, we might also extend the API to use Java 8 `java.time.` equivalents.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---