You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2018/01/30 14:49:46 UTC
[isis] 01/03: ISIS-1569: removes usage of deprecated annotations in
Command iterface
This is an automated email from the ASF dual-hosted git repository.
danhaywood pushed a commit to branch maint-1.16.1
in repository https://gitbox.apache.org/repos/asf/isis.git
commit a821fa2b4432f0f2231eb0039827023a518e0c22
Author: Dan Haywood <da...@haywood-associates.co.uk>
AuthorDate: Tue Jan 30 11:44:29 2018 +0000
ISIS-1569: removes usage of deprecated annotations in Command iterface
---
.../isis/applib/services/command/Command.java | 40 +++++++++++++---------
1 file changed, 24 insertions(+), 16 deletions(-)
diff --git a/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java b/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
index ec91580..0ae75e1 100644
--- a/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
+++ b/core/applib/src/main/java/org/apache/isis/applib/services/command/Command.java
@@ -22,7 +22,6 @@ import org.apache.isis.applib.Identifier;
import org.apache.isis.applib.annotation.Action;
import org.apache.isis.applib.annotation.Command.ExecuteIn;
import org.apache.isis.applib.annotation.Command.Persistence;
-import org.apache.isis.applib.annotation.Optional;
import org.apache.isis.applib.annotation.Programmatic;
import org.apache.isis.applib.clock.Clock;
import org.apache.isis.applib.services.HasTransactionId;
@@ -278,7 +277,7 @@ public interface Command extends HasTransactionId {
//endregion
- //region > startedAt (property, deprecated)
+ //region > startedAt (property)
/**
* For an command that has actually been executed, holds the date/time at which the {@link Interaction} that
@@ -286,8 +285,8 @@ public interface Command extends HasTransactionId {
*
* <p>
* Previously this field was deprecated (on the basis that the startedAt is also held in
- * {@link Interaction.Execution#getStartedAt()}). However, to support replay/replication feature means that
- * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * {@link Interaction.Execution#getStartedAt()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
* </p>
*
* See also {@link Interaction#getCurrentExecution()} and
@@ -301,8 +300,8 @@ public interface Command extends HasTransactionId {
*
* <p>
* Previously this field was deprecated (on the basis that the completedAt is also held in
- * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
- * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * {@link Interaction.Execution#getCompletedAt()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
* </p>
*
* See also {@link Interaction#getCurrentExecution()} and
@@ -320,8 +319,8 @@ public interface Command extends HasTransactionId {
*
* <p>
* Previously this field was deprecated (on the basis that the completedAt is also held in
- * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
- * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * {@link Interaction.Execution#getCompletedAt()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
* </p>
*
* See also {@link Interaction#getCurrentExecution()} and
@@ -334,8 +333,8 @@ public interface Command extends HasTransactionId {
*
* <p>
* Previously this field was deprecated (on the basis that the completedAt is also held in
- * {@link Interaction.Execution#getCompletedAt()}). However, to support replay/replication feature means that
- * we need to query for persisted {@link Command}s and use this field to ensure the correct ordering.
+ * {@link Interaction.Execution#getCompletedAt()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
* </p>
*
* See also {@link Interaction#getCurrentExecution()} and
@@ -366,10 +365,14 @@ public interface Command extends HasTransactionId {
* For an command that has actually been executed, holds the exception stack
* trace if the action invocation/property modification threw an exception.
*
- * @deprecated - see {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getThrew()} instead.
+ * <p>
+ * Previously this field was deprecated (on the basis that the exception is also held in
+ * {@link Interaction.Execution#getThrew()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getThrew()}.
*/
- @Deprecated
- @Optional
String getException();
/**
@@ -384,10 +387,15 @@ public interface Command extends HasTransactionId {
/**
* For an command that has actually been executed, holds a {@link Bookmark} to the object returned by the corresponding action/property modification.
- *
- * @deprecated - see {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getReturned()} instead.
+ *
+ * <p>
+ * Previously this field was deprecated (on the basis that the returned value is also held in
+ * {@link Interaction.Execution#getReturned()}). However, this property is now used in master/slave
+ * replay scenarios which may query a persisted Command.
+ * </p>
+ *
+ * See also {@link Interaction#getCurrentExecution()} and {@link org.apache.isis.applib.services.iactn.Interaction.Execution#getReturned()}.
*/
- @Deprecated
Bookmark getResult();
/**
--
To stop receiving notification emails like this one, please contact
danhaywood@apache.org.