You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Andrushika (via GitHub)" <gi...@apache.org> on 2026/08/18 17:42:40 UTC
[PR] Fail loudly when a UI dev server dies in breeze dev mode [airflow]
Andrushika opened a new pull request, #71784:
URL: https://github.com/apache/airflow/pull/71784
## Why
Follow-up PR of #71241.
In the prek hook `compile-ui-assets-dev`, the script starts the Vite dev server using `Popen`then drops the handles immediately, so a dev server that dies later is never detected.
What's even worse: on macOS, the dead child's SIGCHLD wakes `signal.pause()`, so the script exits 0 and reports success while the browser shows a blank page.
## What
Keep both `Popen` handles and poll them every second instead of calling `signal.pause()`.
The pre-hook always starts two Vite dev servers. (port 5173 for UI, 5174 for Simple auth manager)
When any of them exits, the script prints which server died with its exit code and log file, stops the other one, and exits 1. Polling avoids SIGCHLD handling on purpose, since the platform-specific `pause()` wakeup above is what made the old failure silent.
related: #71241
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes — Claude Code (Fable 5)
Generated-by: Claude Code (Fable 5) following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fail loudly when a UI dev server dies in breeze dev mode [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #71784:
URL: https://github.com/apache/airflow/pull/71784
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fail loudly when a UI dev server dies in breeze dev mode [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #71784:
URL: https://github.com/apache/airflow/pull/71784#issuecomment-5357588464
### Backport successfully created: v3-3-test
Note: As of [Merging PRs targeted for Airflow 3.X](https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#merging-prs-targeted-for-airflow-3x)
the committer who merges the PR is responsible for backporting the PRs that are bug fixes (generally speaking) to the maintenance branches.
In matter of doubt please ask in [#release-management](https://apache-airflow.slack.com/archives/C03G9H97MM2) Slack channel.
<table>
<tr>
<th>Status</th>
<th>Branch</th>
<th>Result</th>
</tr>
<tr>
<td>✅</td>
<td>v3-3-test</td>
<td><a href="https://github.com/apache/airflow/pull/71887"><img src="https://img.shields.io/badge/PR-71887-blue" alt="PR Link"></a></td>
</tr>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org