[GitHub] [lucene] mikemccand commented on pull request #762: LUCENE-10482 Allow users to create their own DirectoryTaxonomyReaders with empty taxoArrays instead of letting the taxoEpoch decide

[GitBox <gi...@apache.org>]

mikemccand commented on PR #762:
URL: https://github.com/apache/lucene/pull/762#issuecomment-1096620694

   > Ooof this new commit was quite a journey. The test case sporadically started failing after I added the two use cases (of testing both the DTR and ARDTR). This led me down to debugging and figuring out that the test-framework randomly adds files and folders to empty directories just to chaos test the setup. It then also randomly disables deletes in directories through VirusChecker and WindowsFS. Accounting for these factors finally made the test case work.
   > 
   > Directly modifying index files is not easy :) 
   > 
   > 
   > 
   > We now also check explictly for the older label "a" and ensure that the new commit label "b" can't be found.
   
   Thanks for persisting @gautamworah96!  Indeed the randomized file system behavior (the occasional `extraN` files!) is exciting when it strikes.  And simulated virus checkers holding files open is also exciting.  Lucene's randomized testing infra is awesome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org