[jira] [Commented] (ORC-172) Fix C++ build issue with Centos6

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15971391#comment-15971391 ] 

ASF GitHub Bot commented on ORC-172:
------------------------------------

GitHub user majetideepak opened a pull request:

    https://github.com/apache/orc/pull/109

    ORC-172: Fix C++ build issue with Centos6

    Use shared_ptr instead of unique_ptr. This is okay since this code is not on the critical path.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/majetideepak/orc ORCDocker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/orc/pull/109.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #109
    
----
commit e27b8de08d0d27cb20fb0b68f6221593b36759fd
Author: Deepak Majeti <de...@hpe.com>
Date:   2017-04-17T11:51:05Z

    replace unique_ptr with shared_ptr

----


> Fix C++ build issue with Centos6
> --------------------------------
>
>                 Key: ORC-172
>                 URL: https://issues.apache.org/jira/browse/ORC-172
>             Project: ORC
>          Issue Type: Bug
>            Reporter: Deepak Majeti
>            Assignee: Deepak Majeti
>
> The patch for ORC-122 requires explicit {{copy}} and {{move}} of the {{Timezone}} class since it contains a {{unique_ptr}} as one of its member. The simpler fix is to make the member a {{shared_ptr}}. A similar change is made for the {{TimezoneCache}}.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)