[GitHub] rabbah commented on a change in pull request #3126: Throttle log messages when rescheduling containers

[GitBox <gi...@apache.org>]

rabbah commented on a change in pull request #3126: Throttle log messages when rescheduling containers
URL: https://github.com/apache/incubator-openwhisk/pull/3126#discussion_r158300632
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
 ##########
 @@ -110,8 +111,15 @@ class ContainerPool(childFactory: ActorRefFactory => ActorRef,
           freePool = freePool - actor
           actor ! r // forwards the run request to the container
         case None =>
-          logging.error(this, "Rescheduling Run message, too many message in the pool")(r.msg.transid)
-          self ! r
+          if (r.retryCount % logRetriesInterval == 0) {
 
 Review comment:
   does it make sense to do this time based? ie every 10seconds?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services