You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by dw...@apache.org on 2018/08/29 08:51:13 UTC

[1/2] lucene-solr:master: SOLR-12360: fully numeric host names are valid based on RFC1123, so this test makes no sense.

Repository: lucene-solr
Updated Branches:
  refs/heads/branch_7x 9fba41a72 -> fec2bf5d1
  refs/heads/master ce504f4f8 -> 545b0dcd0


SOLR-12360: fully numeric host names are valid based on RFC1123, so this test makes no sense.


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/545b0dcd
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/545b0dcd
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/545b0dcd

Branch: refs/heads/master
Commit: 545b0dcd04c795d94093d857ede481132c6fc0ce
Parents: ce504f4
Author: Dawid Weiss <dw...@apache.org>
Authored: Wed Aug 29 10:50:55 2018 +0200
Committer: Dawid Weiss <dw...@apache.org>
Committed: Wed Aug 29 10:50:55 2018 +0200

----------------------------------------------------------------------
 .../src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/545b0dcd/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java b/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
index 8c4006d..f379bbf 100644
--- a/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
@@ -32,6 +32,7 @@ import org.apache.solr.common.cloud.rule.ImplicitSnitch;
 import org.apache.solr.common.cloud.rule.SnitchContext;
 import org.apache.zookeeper.KeeperException;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 
@@ -100,6 +101,7 @@ public class ImplicitSnitchTest extends LuceneTestCase {
   }
 
   @Test
+  @Ignore("SOLR-12360: local DNS resolver may return some address for a host named '192.168.1.2.1'")
   public void testGetTags_with_wrong_ipv4_format_ip_returns_nothing() throws Exception {
     String node = "192.168.1.2.1:8983_solr";
 


[2/2] lucene-solr:branch_7x: SOLR-12360: fully numeric host names are valid based on RFC1123, so this test makes no sense.

Posted by dw...@apache.org.
SOLR-12360: fully numeric host names are valid based on RFC1123, so this test makes no sense.


Project: http://git-wip-us.apache.org/repos/asf/lucene-solr/repo
Commit: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/fec2bf5d
Tree: http://git-wip-us.apache.org/repos/asf/lucene-solr/tree/fec2bf5d
Diff: http://git-wip-us.apache.org/repos/asf/lucene-solr/diff/fec2bf5d

Branch: refs/heads/branch_7x
Commit: fec2bf5d1c12441254116f2b406eebecd14d56bd
Parents: 9fba41a
Author: Dawid Weiss <dw...@apache.org>
Authored: Wed Aug 29 10:50:55 2018 +0200
Committer: Dawid Weiss <dw...@apache.org>
Committed: Wed Aug 29 10:51:06 2018 +0200

----------------------------------------------------------------------
 .../src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java    | 2 ++
 1 file changed, 2 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/lucene-solr/blob/fec2bf5d/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
----------------------------------------------------------------------
diff --git a/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java b/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
index 8c4006d..f379bbf 100644
--- a/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
+++ b/solr/core/src/test/org/apache/solr/cloud/rule/ImplicitSnitchTest.java
@@ -32,6 +32,7 @@ import org.apache.solr.common.cloud.rule.ImplicitSnitch;
 import org.apache.solr.common.cloud.rule.SnitchContext;
 import org.apache.zookeeper.KeeperException;
 import org.junit.Before;
+import org.junit.Ignore;
 import org.junit.Test;
 import org.mockito.Mockito;
 
@@ -100,6 +101,7 @@ public class ImplicitSnitchTest extends LuceneTestCase {
   }
 
   @Test
+  @Ignore("SOLR-12360: local DNS resolver may return some address for a host named '192.168.1.2.1'")
   public void testGetTags_with_wrong_ipv4_format_ip_returns_nothing() throws Exception {
     String node = "192.168.1.2.1:8983_solr";