You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Robert Scholte <rf...@apache.org> on 2016/07/09 11:47:51 UTC
Re: svn commit: r1751975 - in /maven/shared/trunk/maven-shared-utils:
pom.xml
src/main/java/org/apache/maven/shared/utils/cli/javatool/AbstractJavaTool.java
src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java
Hi Hervé,
This will already break backwards compatibility because the signature has
changed. In other words: projects using this method need to be recompiled;
they can't simply switch to this version.
So is it worth keeping this piece of code here?
Robert
On Sat, 09 Jul 2016 00:32:00 +0200, <hb...@apache.org> wrote:
> ---
> maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java
> (original)
> +++
> maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java
> Fri Jul 8 22:32:00 2016
> @@ -19,8 +19,6 @@ package org.apache.maven.shared.utils.cl
> * under the License.
> */
> -import org.apache.maven.toolchain.Toolchain;
> -
> /**
> * Describes a java tool, means a executable available in the jdk.
> * <p/>
> @@ -51,8 +49,10 @@ public interface JavaTool<Request extend
> * Set an optional tool chain to find out the java tool executable
> location.
> *
> * @param toolchain optional tool chain to find out the java tool
> executable location.
> + * To avoid direct dependency on Maven core, this parameter is an
> Object that will be
> + * used as Toolchain through reflection
> */
> - void setToolchain( Toolchain toolchain );
> + void setToolchain( Object toolchain );
> /**
> * Execute the input request and then returns the result of the
> execution.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r1751975 - in /maven/shared/trunk/maven-shared-utils: pom.xml src/main/java/org/apache/maven/shared/utils/cli/javatool/AbstractJavaTool.java src/main/java/org/apache/maven/shared/utils/cli/javatool/JavaTool.java
Posted by Hervé BOUTEMY <he...@free.fr>.
when they will upgrade their dependency version, they'll recompile: I don't
really know where (if) this code is used, but I don't expect to get binary
compatibility issues in real life on this
yes, probably moving this whole cli/javatool somewhere else would be a better
choice: but I don't know where. And since I don't know where this code is
used, I'm just doing the work to be able to release a maven-shared-utils that
can be used in Maven core
But if you know how to move the code, don't hesitate to do so: now that I took
time to really discover it, I'm sure it should not have landed here, or it
should have been written in another way
Regards,
Hervé
Le samedi 9 juillet 2016 13:47:51 Robert Scholte a écrit :
> Hi Hervé,
>
> This will already break backwards compatibility because the signature has
> changed. In other words: projects using this method need to be recompiled;
> they can't simply switch to this version.
> So is it worth keeping this piece of code here?
>
> Robert
>
> On Sat, 09 Jul 2016 00:32:00 +0200, <hb...@apache.org> wrote:
> > ---
> > maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/share
> > d/utils/cli/javatool/JavaTool.java (original)
> > +++
> > maven/shared/trunk/maven-shared-utils/src/main/java/org/apache/maven/share
> > d/utils/cli/javatool/JavaTool.java Fri Jul 8 22:32:00 2016
> > @@ -19,8 +19,6 @@ package org.apache.maven.shared.utils.cl
> >
> > * under the License.
> > */
> >
> > -import org.apache.maven.toolchain.Toolchain;
> > -
> >
> > /**
> >
> > * Describes a java tool, means a executable available in the jdk.
> > * <p/>
> >
> > @@ -51,8 +49,10 @@ public interface JavaTool<Request extend
> >
> > * Set an optional tool chain to find out the java tool executable
> >
> > location.
> >
> > *
> > * @param toolchain optional tool chain to find out the java tool
> >
> > executable location.
> > + * To avoid direct dependency on Maven core, this parameter is an
> > Object that will be
> > + * used as Toolchain through reflection
> >
> > */
> >
> > - void setToolchain( Toolchain toolchain );
> > + void setToolchain( Object toolchain );
> >
> > /**
> >
> > * Execute the input request and then returns the result of the
> >
> > execution.
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org