You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/01/17 08:48:56 UTC
[GitHub] [apisix-dashboard] guoqqqi opened a new pull request #1317: fix: cannot delete multiple plugins without page refreshing
guoqqqi opened a new pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [x] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
resolve #1316
Update the plugin data after deleting a plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-766610362
@guoqqqi CI failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559110949
##########
File path: web/src/pages/Plugin/List.tsx
##########
@@ -79,6 +79,7 @@ const Page: React.FC = () => {
const plugins = omit(initialData, [`${record.name}`]);
createOrUpdate({ plugins }).then(() => {
ref.current?.reload();
+ setInitialData(plugins);
Review comment:
The test case needs to make sure it could delete multiple plugins successfully.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ab5b869) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 63.00% +18.80%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1487 +626
+ Misses 975 697 -278
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `51.51% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...ab5b869](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (b01d57d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.12%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.31% +0.12%
==========================================
Files 31 32 +1
Lines 1948 1963 +15
==========================================
+ Hits 861 870 +9
- Misses 975 981 +6
Partials 112 112
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.00% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...b01d57d](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ef21238) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 62.62% +18.42%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1478 +617
+ Misses 975 706 -269
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `48.48% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...ef21238](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559285619
##########
File path: web/cypress/support/commands.js
##########
@@ -35,7 +35,7 @@ Cypress.Commands.add('login', () => {
});
});
-Cypress.Commands.add('addPlugins', () => {
+Cypress.Commands.add('addPlugins', (cases) => {
Review comment:
`cases` is an array (variable), and should replace `this.cases`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559277963
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const domSelectors = {
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('plugin-list.json').as('cases');
+ });
+
+ it('should create plugins', () => {
+ cy.visit('/');
+ cy.contains('Plugin').click();
+ cy.contains('Create').click();
+
+ // add test plugins
+ cy.addPlugins();
Review comment:
https://github.com/apache/apisix-dashboard/pull/1317/files#diff-5b8ddd39c2c1c0c56ef78ba6284324b57b0660d1d0eb5569cf59acf760fecd3bR38
##########
File path: web/cypress/support/commands.js
##########
@@ -34,3 +34,81 @@ Cypress.Commands.add('login', () => {
localStorage.setItem('umi_locale', 'en-US');
});
});
+
+Cypress.Commands.add('addPlugins', () => {
Review comment:
This function would better receive a parameter `cases`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (0a94c69) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
- Coverage 44.19% 44.14% -0.06%
==========================================
Files 31 31
Lines 1948 1948
==========================================
- Hits 861 860 -1
- Misses 975 976 +1
Partials 112 112
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.88% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...0a94c69](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-766135667
@guoqqqi CI failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r563287469
##########
File path: web/cypress/support/commands.js
##########
@@ -65,6 +65,7 @@ Cypress.Commands.add('configurePlugins', (cases) => {
});
// NOTE: wait for the Drawer to appear on the DOM
+ cy.get({ timeout });
Review comment:
We can use timeout to replace those useless wait
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (b7c7c4f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.42%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 62.62% +18.42%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1478 +617
+ Misses 975 706 -269
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `46.46% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...b7c7c4f](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (c9ea15c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.31% +0.11%
==========================================
Files 31 32 +1
Lines 1948 1961 +13
==========================================
+ Hits 861 869 +8
- Misses 975 981 +6
+ Partials 112 111 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.37% <0.00%> (+0.87%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...c9ea15c](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
LiteSun commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559273332
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const domSelectors = {
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('plugin-list.json').as('cases');
+ });
+
+ it('should create plugins', () => {
+ cy.visit('/');
+ cy.contains('Plugin').click();
+ cy.contains('Create').click();
+
+ // add test plugins
+ cy.addPlugins();
Review comment:
what does `addPlugins` mean? Did you mean `testPlugins`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ef21238) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.36% +0.16%
==========================================
Files 31 32 +1
Lines 1948 1961 +13
==========================================
+ Hits 861 870 +9
- Misses 975 980 +5
+ Partials 112 111 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `81.01% <0.00%> (+1.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...ef21238](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (148fe0f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 31 31
Lines 1948 1948
=======================================
Hits 861 861
Misses 975 975
Partials 112 112
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...148fe0f](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r563219769
##########
File path: web/cypress/integration/plugin/schema-smocktest.spec.js
##########
@@ -31,6 +31,7 @@ context('smoke test for plugin schema', () => {
cy.contains('Plugin').click();
cy.contains('Create').click();
+ // add test plugins
Review comment:
If your codes are clear, no need to add this tip.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (bd06d0c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **decrease** coverage by `0.05%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
- Coverage 44.19% 44.14% -0.06%
==========================================
Files 31 31
Lines 1948 1948
==========================================
- Hits 861 860 -1
- Misses 975 976 +1
Partials 112 112
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `78.88% <0.00%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...bd06d0c](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (b7c7c4f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.36% +0.16%
==========================================
Files 31 32 +1
Lines 1948 1961 +13
==========================================
+ Hits 861 870 +9
- Misses 975 980 +5
+ Partials 112 111 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `81.01% <0.00%> (+1.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...b7c7c4f](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (1819bbe) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.47%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 62.66% +18.47%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1479 +618
+ Misses 975 705 -270
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `48.48% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...1819bbe](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ab5b869) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 63.00% +18.80%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1487 +626
+ Misses 975 697 -278
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `51.51% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...7cc3666](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559172618
##########
File path: web/cypress/fixtures/pluginList.json
##########
@@ -0,0 +1,41 @@
+{
Review comment:
The file name should be like `a-b-c.json`
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const timeout = 50000;
+ const domSelectors = {
+ name: '[data-cy-plugin-name]',
+ parents: '.ant-card-bordered',
+ drawer: '.ant-drawer-content',
+ switch: '#disable',
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('pluginList.json').as('cases');
+ });
+
+ it('should create plugin', () => {
Review comment:
```suggestion
it('should create plugins', () => {
```
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const timeout = 50000;
+ const domSelectors = {
+ name: '[data-cy-plugin-name]',
+ parents: '.ant-card-bordered',
+ drawer: '.ant-drawer-content',
+ switch: '#disable',
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('pluginList.json').as('cases');
+ });
+
+ it('should create plugin', () => {
+ cy.visit('/');
+ cy.contains('Plugin').click();
+ cy.contains('Create').click();
+
+ cy.get(domSelectors.name).then(function (cards) {
Review comment:
How about making this function global?
##########
File path: web/cypress/fixtures/pluginList.json
##########
@@ -0,0 +1,41 @@
+{
Review comment:
and why not use data from another schema data file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r560167129
##########
File path: web/cypress/support/commands.js
##########
@@ -35,7 +35,7 @@ Cypress.Commands.add('login', () => {
});
});
-Cypress.Commands.add('addPlugins', () => {
+Cypress.Commands.add('addPlugins', (cases) => {
Review comment:
ping
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ab5b869) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.36% +0.16%
==========================================
Files 31 32 +1
Lines 1948 1961 +13
==========================================
+ Hits 861 870 +9
- Misses 975 980 +5
+ Partials 112 111 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `81.01% <0.00%> (+1.50%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...ab5b869](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan closed pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (1819bbe) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `0.11%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
==========================================
+ Coverage 44.19% 44.31% +0.11%
==========================================
Files 31 32 +1
Lines 1948 1961 +13
==========================================
+ Hits 861 869 +8
- Misses 975 981 +6
+ Partials 112 111 -1
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `61.01% <0.00%> (-0.39%)` | :arrow_down: |
| [api/internal/filter/recover.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZWNvdmVyLmdv) | `0.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `46.52% <0.00%> (+0.03%)` | :arrow_up: |
| [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `28.28% <0.00%> (+0.44%)` | :arrow_up: |
| [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.66% <0.00%> (+0.49%)` | :arrow_up: |
| [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (+0.78%)` | :arrow_up: |
| [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `80.37% <0.00%> (+0.87%)` | :arrow_up: |
| [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `30.97% <0.00%> (+1.36%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...1819bbe](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (00654d6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 31 31
Lines 1948 1948
=======================================
Hits 861 861
Misses 975 975
Partials 112 112
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...00654d6](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r563225304
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -40,15 +42,15 @@ context('Create and Delete Plugin List', () => {
it('should delete plugin list', () => {
cy.visit('/');
cy.contains('Plugin').click();
-
- cy.wait(500);
+
Review comment:
extra spaces
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (ab5b869) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 63.00% +18.80%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1487 +626
+ Misses 975 697 -278
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `51.51% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...7cc3666](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan merged pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-767227681
Hi，I will fix it at https://github.com/apache/apisix-dashboard/pull/1372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (b01d57d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.51%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 62.71% +18.51%
===========================================
Files 31 41 +10
Lines 1948 2352 +404
===========================================
+ Hits 861 1475 +614
+ Misses 975 701 -274
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `44.94% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...b01d57d](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r559110679
##########
File path: web/src/pages/Plugin/List.tsx
##########
@@ -79,6 +79,7 @@ const Page: React.FC = () => {
const plugins = omit(initialData, [`${record.name}`]);
createOrUpdate({ plugins }).then(() => {
ref.current?.reload();
+ setInitialData(plugins);
Review comment:
testcase, please.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
guoqqqi commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-767227681
Hi，I will fix it at https://github.com/apache/apisix-dashboard/pull/1372
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r563244796
##########
File path: web/cypress/support/commands.js
##########
@@ -65,6 +65,7 @@ Cypress.Commands.add('configurePlugins', (cases) => {
});
// NOTE: wait for the Drawer to appear on the DOM
+ cy.get({ timeout });
Review comment:
get what?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (34a272f) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
=======================================
Coverage 44.19% 44.19%
=======================================
Files 31 31
Lines 1948 1948
=======================================
Hits 861 861
Misses 975 975
Partials 112 112
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...34a272f](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on a change in pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#discussion_r563166817
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const domSelectors = {
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('plugin-list.json').as('cases');
Review comment:
why not use https://github.com/guoqqqi/apisix-dashboard/blob/fix-globalPlugin/web/cypress/fixtures/plugin-dataset.json and choose part of cases?
##########
File path: web/cypress/integration/plugin/create_and_delete_plugin.spec.js
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+/* eslint-disable no-undef */
+
+context('Create and Delete Plugin List', () => {
+ const domSelectors = {
+ tableCell: '.ant-table-cell',
+ empty: '.ant-empty-normal',
+ };
+
+ beforeEach(() => {
+ cy.login();
+
+ cy.fixture('plugin-list.json').as('cases');
+ });
+
+ it('should create plugins', function () {
+ cy.visit('/');
+ cy.contains('Plugin').click();
+ cy.contains('Create').click();
+
+ // add test plugins
+ cy.addPlugins(this.cases);
Review comment:
not a good name, `configurePlugins`
##########
File path: web/cypress/support/commands.js
##########
@@ -34,3 +34,81 @@ Cypress.Commands.add('login', () => {
localStorage.setItem('umi_locale', 'en-US');
});
});
+
+Cypress.Commands.add('addPlugins', (cases) => {
+ const timeout = 50000;
+ const domSelectors = {
+ name: '[data-cy-plugin-name]',
+ parents: '.ant-card-bordered',
+ drawer: '.ant-drawer-content',
+ switch: '#disable',
+ close: '.anticon-close',
+ };
+
+ cy.get(domSelectors.name).then(function (cards) {
+ [...cards].forEach((card) => {
+ const name = card.innerText;
+ const pluginCases = cases[name] || [];
+ // eslint-disable-next-line consistent-return
+ pluginCases.forEach(({ shouldValid, data, type = '' }) => {
+ /**
+ * NOTE: This test is mainly for GlobalPlugin, which is using non-consumer-type schema.
+ */
Review comment:
No need those tips
##########
File path: web/cypress/support/commands.js
##########
@@ -34,3 +34,81 @@ Cypress.Commands.add('login', () => {
localStorage.setItem('umi_locale', 'en-US');
});
});
+
+Cypress.Commands.add('addPlugins', (cases) => {
+ const timeout = 50000;
+ const domSelectors = {
+ name: '[data-cy-plugin-name]',
+ parents: '.ant-card-bordered',
+ drawer: '.ant-drawer-content',
+ switch: '#disable',
+ close: '.anticon-close',
+ };
+
+ cy.get(domSelectors.name).then(function (cards) {
+ [...cards].forEach((card) => {
+ const name = card.innerText;
+ const pluginCases = cases[name] || [];
+ // eslint-disable-next-line consistent-return
+ pluginCases.forEach(({ shouldValid, data, type = '' }) => {
+ /**
+ * NOTE: This test is mainly for GlobalPlugin, which is using non-consumer-type schema.
+ */
Review comment:
because this is a public function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-766610362
@guoqqqi CI failed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1317: fix: cannot delete multiple plugins without page refreshing
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1317:
URL: https://github.com/apache/apisix-dashboard/pull/1317#issuecomment-761756678
# [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=h1) Report
> Merging [#1317](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=desc) (c9ea15c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/754f5598706fe5dfe9a09bf0d51d0701406c692c?el=desc) (754f559) will **increase** coverage by `18.80%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1317 +/- ##
===========================================
+ Coverage 44.19% 63.00% +18.80%
===========================================
Files 31 41 +10
Lines 1948 2360 +412
===========================================
+ Hits 861 1487 +626
+ Misses 975 697 -278
- Partials 112 176 +64
```
| [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `52.52% <0.00%> (ø)` | |
| [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | `0.00% <0.00%> (ø)` | |
| [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `77.08% <0.00%> (ø)` | |
| [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (ø)` | |
| [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `83.87% <0.00%> (ø)` | |
| [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `73.80% <0.00%> (ø)` | |
| [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `50.00% <0.00%> (ø)` | |
| [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | `0.00% <0.00%> (ø)` | |
| [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | `60.86% <0.00%> (ø)` | |
| [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `67.85% <0.00%> (ø)` | |
| ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1317/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=footer). Last update [754f559...c9ea15c](https://codecov.io/gh/apache/apisix-dashboard/pull/1317?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org