You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by dineshappavoo <gi...@git.apache.org> on 2018/11/15 22:59:50 UTC
[GitHub] zookeeper pull request #702: ZOOKEEPER-3190: Spell check on the Zookeeper se...
GitHub user dineshappavoo opened a pull request:
https://github.com/apache/zookeeper/pull/702
ZOOKEEPER-3190: Spell check on the Zookeeper server files
This pull request is to do spell check on the zookeeper server files [ zookeeper/zookeeper-server/src/main/java/org/apache/zookeeper/server ] for a newbie to understand the process.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dineshappavoo/zookeeper ZOOKEEPER-3190
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/702.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #702
----
commit 3bfc21fd5a72b675ceebfcf6b53aa7d7e7a85393
Author: dappavoo <da...@...>
Date: 2018-11-15T21:19:49Z
ZOOKEEPER-3190: Spell check on the Zookeeper server files
----
---
[GitHub] zookeeper issue #702: ZOOKEEPER-3190: Spell check on the Zookeeper server fi...
Posted by dineshappavoo <gi...@git.apache.org>.
Github user dineshappavoo commented on the issue:
https://github.com/apache/zookeeper/pull/702
Thank you @eolivelli for the review. Addressed your comments.
---
[GitHub] zookeeper pull request #702: ZOOKEEPER-3190: Spell check on the Zookeeper se...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zookeeper/pull/702
---
[GitHub] zookeeper pull request #702: ZOOKEEPER-3190: Spell check on the Zookeeper se...
Posted by eolivelli <gi...@git.apache.org>.
Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/702#discussion_r234101680
--- Diff: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/auth/QuorumAuth.java ---
@@ -38,10 +38,10 @@
public static final String QUORUM_KERBEROS_SERVICE_PRINCIPAL_DEFAULT_VALUE = "zkquorum/localhost";
public static final String QUORUM_LEARNER_SASL_LOGIN_CONTEXT = "quorum.auth.learner.saslLoginContext";
- public static final String QUORUM_LEARNER_SASL_LOGIN_CONTEXT_DFAULT_VALUE = "QuorumLearner";
+ public static final String QUORUM_LEARNER_SASL_LOGIN_CONTEXT_DEFAULT_VALUE = "QuorumLearner";
--- End diff --
IMHO it is better not to change is constants, they are part of a public API
---