You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@cassandra.apache.org by "frankgh (via GitHub)" <gi...@apache.org> on 2023/06/05 23:54:35 UTC
[GitHub] [cassandra-sidecar] frankgh commented on a diff in pull request #48: CASSANDRASC-51: Use in-jvm dtest framework for integration tests.
frankgh commented on code in PR #48:
URL: https://github.com/apache/cassandra-sidecar/pull/48#discussion_r1218719797
##########
.circleci/config.yml:
##########
@@ -56,56 +57,14 @@ jobs:
- store_test_results:
path: ~/repo/build/test-results/
- # Runs java 8 tests on a VM to be able to run Docker for integration tests
- java8:
- <<: *base_job
-
- steps:
- - checkout
- - install_common
-
- - install_java:
- version: adoptopenjdk-8-hotspot
- - run: sudo update-java-alternatives -s adoptopenjdk-8-hotspot-amd64 && java -version
- - run: ./gradlew -i clean test integrationTest --stacktrace
-
- - store_artifacts:
- path: build/reports
- destination: test-reports
-
- - store_test_results:
- path: ~/repo/build/test-results/
-
- - store_test_results:
- path: ~/repo/cassandra-integration-tests/build/test-results/
-
# Runs java 11 tests on a docker image
- java11_docker:
+ java11:
docker:
- image: circleci/openjdk:11-jdk-stretch
steps:
- checkout
- - run: ./gradlew -i clean test -x integrationTest --stacktrace
-
- - store_artifacts:
- path: build/reports
- destination: test-reports
-
- - store_test_results:
- path: ~/repo/build/test-results/
-
- # Runs java 11 tests on a VM to be able to run Docker for integration tests
- java11:
- <<: *base_job
-
- steps:
- - checkout
- - install_common
-
- - install_java:
- version: adoptopenjdk-11-hotspot
- - run: sudo update-java-alternatives -s adoptopenjdk-11-hotspot-amd64 && java -version
+ - run: scripts/build-dtest-jars.sh
Review Comment:
```suggestion
- run:
command: scripts/build-dtest-jars.sh
environment:
CASSANDRA_USE_JDK11: true
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org