[PR] feat: add function and dml Doris sql cases [shardingsphere]

["TrackAir (via GitHub)" <gi...@apache.org>]

TrackAir opened a new pull request, #31535:
URL: https://github.com/apache/shardingsphere/pull/31535

   Fixes #31484.
   
   Changes proposed in this pull request:
     - add function and dml Doris sql cases
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   
    My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   
   - [x]  I have self-reviewed the commit code.
   - [x]  I have (or in comment I request) added corresponding labels for the pull request.
   - [x]  I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
   - [x]  I have made corresponding changes to the documentation.
   - [x]  I have added corresponding unit tests for my changes.
   
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] feat: add function and dml Doris sql cases [shardingsphere]

["strongduanmu (via GitHub)" <gi...@apache.org>]

strongduanmu commented on code in PR #31535:
URL: https://github.com/apache/shardingsphere/pull/31535#discussion_r1625246619


##########
test/it/parser/src/main/resources/case/ddl/create-encrypt.xml:
##########
@@ -16,18 +16,6 @@
   ~ limitations under the License.
   -->
 
-<project version="4">

Review Comment:
   Why remove this config?



##########
test/it/parser/src/main/resources/sql/unsupported/unsupported.xml:
##########
@@ -324,6 +324,11 @@
     <sql-case id="assert_show_databases_parse_conflict" value="SHOW DATABASES" db-types="Oracle" />
     <sql-case id="assert_show_schemas_parse_conflict" value="SHOW SCHEMAS" db-types="Oracle" />
     <sql-case id="assert_show_tables_parse_conflict" value="SHOW TABLES" db-types="Oracle" />
+    <sql-case id="alter_view_definition" value="ALTER VIEW order_view AS SELECT * FROM t_order" db-types="Doris" />
+    <sql-case id="create_encrypt" value="CREATE ENCRYPTKEY my_key AS 'ABCD123456789'" db-types="Doris" />
     <!-- TODO open this case when MySQLStatement change to SEMI_? EOF -->
     <!--    <sql-case id="assert_parse_multi_statements" value="SHOW VARIABLES LIKE 'sql_mode'; SELECT COUNT(*) AS support_ndb FROM information_schema;" db-types="MySQL" />-->
+

Review Comment:
   Please remove useless blank line here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org