You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shiro.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/06/22 15:37:07 UTC

[GitHub] [shiro] cstamas opened a new pull request, #308: [SHIRO-816] Hazelcast support does not support HZ v4

cstamas opened a new pull request, #308:
URL: https://github.com/apache/shiro/pull/308

   The reason is that getMap method return value changed, and
   JVM does not find the method (if compiled with HZ3 and runtime
   uses HZ4 - same would happen other way around).
   
   Fix has two parts: determines IMap class (v3 or v4),
   and them use MethodHandle to invoke it.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-1620896474

   Superseded by #1002 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4
URL: https://github.com/apache/shiro/pull/308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-1602860121

   Will rebase for 1.x though


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-1620882691

   Will upgrade to Hz 5.x in Shiro 2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak commented on PR #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-1620880468

   @dependabot recreate


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] bmarwell commented on pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell commented on PR #308:
URL: https://github.com/apache/shiro/pull/308#issuecomment-1602718278

   @cstamas is right. A one-class dependency is probably an overkill for most users. I will suggest to drop it completely, so this becomes a `won't fix`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] bmarwell closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "bmarwell (via GitHub)" <gi...@apache.org>.
bmarwell closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4
URL: https://github.com/apache/shiro/pull/308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shiro] lprimak closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4

Posted by "lprimak (via GitHub)" <gi...@apache.org>.
lprimak closed pull request #308: [SHIRO-816] Hazelcast support does not support HZ v4
URL: https://github.com/apache/shiro/pull/308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@shiro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org