You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2014/10/28 02:57:51 UTC

Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-8615
    https://issues.apache.org/jira/browse/HIVE-8615


Repository: hive-git


Description
-------

https://issues.apache.org/jira/browse/HIVE-8615


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
  beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
  beeline/src/main/resources/BeeLine.properties d40c0dc 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 

Diff: https://reviews.apache.org/r/27263/diff/


Testing
-------

tests added


Thanks,

Thejas Nair

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by Thejas Nair <th...@hortonworks.com>.

> On Oct. 28, 2014, 2:13 a.m., cheng xu wrote:
> > itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java, line 379
> > <https://reviews.apache.org/r/27263/diff/1/?file=734834#file734834line379>
> >
> >     String variable TEST_NAME should be "testDSVOutput"

Thanks for pointing that out. I see that many of the existing tests also have this issue. This whole TEST_NAME string is error prone and unnecessary with junit.
I will clean that up.


- Thejas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/#review58756
-----------------------------------------------------------


On Oct. 28, 2014, 1:58 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27263/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 1:58 a.m.)
> 
> 
> Review request for hive and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-8615
>     https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
>   beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
>   beeline/src/main/resources/BeeLine.properties d40c0dc 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 
> 
> Diff: https://reviews.apache.org/r/27263/diff/
> 
> 
> Testing
> -------
> 
> tests added
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/#review58756
-----------------------------------------------------------


Thank Thejas for your patch. LGTM besides some minor issues.


itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/27263/#comment99900>

    String variable TEST_NAME should be "testDSVOutput"



itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/27263/#comment99901>

    TEST_NAME should be testTSV2Output instead.



itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
<https://reviews.apache.org/r/27263/#comment99902>

    The same as above.


ca

- cheng xu


On Oct. 28, 2014, 1:58 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27263/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 1:58 a.m.)
> 
> 
> Review request for hive and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-8615
>     https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
>   beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
>   beeline/src/main/resources/BeeLine.properties d40c0dc 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 
> 
> Diff: https://reviews.apache.org/r/27263/diff/
> 
> 
> Testing
> -------
> 
> tests added
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by cheng xu <ch...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/#review58760
-----------------------------------------------------------

Ship it!


Thanks for clean up the test class. LGTM!

- cheng xu


On Oct. 28, 2014, 3:12 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27263/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:12 a.m.)
> 
> 
> Review request for hive and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-8615
>     https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
>   beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
>   beeline/src/main/resources/BeeLine.properties d40c0dc 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 
> 
> Diff: https://reviews.apache.org/r/27263/diff/
> 
> 
> Testing
> -------
> 
> tests added
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by Vaibhav Gumashta <vg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/#review58777
-----------------------------------------------------------

Ship it!


Ship It!

- Vaibhav Gumashta


On Oct. 28, 2014, 3:12 a.m., Thejas Nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27263/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 3:12 a.m.)
> 
> 
> Review request for hive and Vaibhav Gumashta.
> 
> 
> Bugs: HIVE-8615
>     https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> https://issues.apache.org/jira/browse/HIVE-8615
> 
> 
> Diffs
> -----
> 
>   beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
>   beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
>   beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
>   beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
>   beeline/src/main/resources/BeeLine.properties d40c0dc 
>   itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 
> 
> Diff: https://reviews.apache.org/r/27263/diff/
> 
> 
> Testing
> -------
> 
> tests added
> 
> 
> Thanks,
> 
> Thejas Nair
> 
>

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 3:12 a.m.)


Review request for hive and Vaibhav Gumashta.


Changes
-------

Cleanup tests to remove the TEST_NAME param, and use MiniHS2


Bugs: HIVE-8615
    https://issues.apache.org/jira/browse/HIVE-8615


Repository: hive-git


Description
-------

https://issues.apache.org/jira/browse/HIVE-8615


Diffs (updated)
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
  beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
  beeline/src/main/resources/BeeLine.properties d40c0dc 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 

Diff: https://reviews.apache.org/r/27263/diff/


Testing
-------

tests added


Thanks,

Thejas Nair

Re: Review Request 27263: HIVE-8615 : beeline csv, tsv outputformat needs backward compatibility mode

Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27263/
-----------------------------------------------------------

(Updated Oct. 28, 2014, 1:58 a.m.)


Review request for hive and Vaibhav Gumashta.


Bugs: HIVE-8615
    https://issues.apache.org/jira/browse/HIVE-8615


Repository: hive-git


Description
-------

https://issues.apache.org/jira/browse/HIVE-8615


Diffs
-----

  beeline/src/java/org/apache/hive/beeline/BeeLine.java e3c2449 
  beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 2a0e9b5 
  beeline/src/java/org/apache/hive/beeline/DeprecatedSeparatedValuesOutputFormat.java PRE-CREATION 
  beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java 6bbb046 
  beeline/src/main/resources/BeeLine.properties d40c0dc 
  itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java 0947b8d 

Diff: https://reviews.apache.org/r/27263/diff/


Testing
-------

tests added


Thanks,

Thejas Nair