You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2018/08/01 15:47:40 UTC
Review Request 68145: Sent an event to resource providers when they
are removed.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/
-----------------------------------------------------------
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
In order to allow proper cleanup the resource provider manager sends a
`REMOVED` to a resource provider when it is being removed.
The event is not sent reliably, i.e., if the resource provider was
e.g., not subscribed when it was removed we currently will never
attempt to resend the event.
Diffs
-----
include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
src/tests/mesos.hpp 8142f3f3ab8e4e9230efdcd2e6846d0e0bd293b2
Diff: https://reviews.apache.org/r/68145/diff/1/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68145: WIP: Sent an event to resource providers
when they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 15, 2018, 2:04 a.m., Chun-Hung Hsiao wrote:
> > I'm not sure if we want to have this. If we are to follow the same pattern as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource provider and prevents future registration?
Removed from the MESOS-8403 chain.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207279
-----------------------------------------------------------
On Aug. 1, 2018, 5:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 5:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: WIP: Sent an event to resource providers
when they are removed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
> On Aug. 15, 2018, 12:04 a.m., Chun-Hung Hsiao wrote:
> > I'm not sure if we want to have this. If we are to follow the same pattern as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource provider and prevents future registration?
>
> Benjamin Bannier wrote:
> Removed from the MESOS-8403 chain.
Actually I changed my mind lol. I went through the master code again and now feel we probably still want to have such a message.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207279
-----------------------------------------------------------
On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207279
-----------------------------------------------------------
I'm not sure if we want to have this. If we are to follow the same pattern as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource provider and prevents future registration?
- Chun-Hung Hsiao
On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: WIP: Sent an event to resource providers
when they are removed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207335
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68143', '68144', '68146', '68147', '68362', '68145']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2162/mesos-review-68145
- Mesos Reviewbot Windows
On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 15, 2018, 9:34 p.m., Chun-Hung Hsiao wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 42 (patched)
> > <https://reviews.apache.org/r/68145/diff/3/?file=2073017#file2073017line42>
> >
> > I prefer `TEARDOWN` (which is what we have in the scheduler API) or `SHUTDOWN` (which is what we have to ask agents to gracefully terminate themselves).
Renamed.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207345
-----------------------------------------------------------
On Aug. 16, 2018, 4:30 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 4:30 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: WIP: Sent an event to resource providers
when they are removed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207345
-----------------------------------------------------------
include/mesos/resource_provider/resource_provider.proto
Lines 42 (patched)
<https://reviews.apache.org/r/68145/#comment290700>
I prefer `TEARDOWN` (which is what we have in the scheduler API) or `SHUTDOWN` (which is what we have to ask agents to gracefully terminate themselves).
- Chun-Hung Hsiao
On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2018, 3:47 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/3/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207412
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68143', '68144', '68146', '68147', '68362', '68145']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2172/mesos-review-68145
- Mesos Reviewbot Windows
On Aug. 16, 2018, 2:30 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:30 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/4/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207454
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68143', '68144', '68146', '68147', '68362', '68145']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2175/mesos-review-68145
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2175/mesos-review-68145/logs/mesos-tests.log):
```
I0816 23:47:42.137460 5088 manager.cpp:161] Terminating resource provider f32541e2-ed3b-4108-a7b3-c29e5125e3a0
I0816 23:47:42.138466 20644 slave.cpp:7636] Handling resource provider message 'SUBSCRIBE: {"id":{"value":"f32541e2-ed3b-4108-a7b3-c29e5125e3a0"},"name":"test","type":"org.apache.mesos.rp.test"}'
E0816 23:47:42.139451 20644 http_connection.hpp:452] End-Of-File received
I0816 23:47:42.140449 5892 slave.cpp:7636] Handling resource provider message 'DISCONNECT: resource provider f32541e2-ed3b-4108-a7b3-c29e5125e3a0'
I0816 23:47:42.140449 5892 slave.cpp:7884] Forwarding new total resources cpus:4; mem:2048; disk:1024; ports:[31000-32000]
I0816 23:47:42.140449 20644 http_connection.hpp:217] Re-detecting endpoint
[libprotobuf FATAL d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\message_lite.cc:281] CHECK failed: IsInitialized(): Can't serialize message of type "mesos.internal.UpdateSlaveMessage" because it is missing required fields: resource_providers.providers[0].resource_version_uuid.value
*** Check failure stack trace: ***
@ 00007FF7C6FD45BB google::LogMessage::Fail
@ 00007FF7C6FD44C1 google::LogMessage::SendToLog
@ 00007FF7C6FD3CA7 google::LogMessage::Flush
@ 00007FF7C6FD57E1 google::LogMessageFatal::~LogMessageFatal
@ 00007FF7C87CE897 `process::ProcessManager::resume'::`1'::catch$11
@ 00007FFA1BA414F0 __C_specific_handler
@ 00007FFA1BA4536A __BuildCatchObjectHelper
@ 00007FFA2A14E273 RtlCaptureContext
@ 00007FF7C6AC1B70 process::ProcessManager::resume
@ 00007FF7C6BF4CD1 ??
@ 00007FF7C6B14480 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF7C6B76280 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> >
@ 00007FF7C6B2A07C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0>
@ 00007FF7C6C4A88A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run
@ 00007FF7C6C35E78 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go
@ 00007FF7C6C1B9AD std::_Pad::_Call_func
@ 00007FFA11123428 _register_onexit_function
@ 00007FFA11123071 _register_onexit_function
@ 00007FFA275E3034 BaseThreadInitThunk
@ 00007FFA2A121431 RtlUserThreadStart
F0816 23:47:42.142452 5892 process.cpp:2990] Aborting libprocess: 'slave(95)@192.10.1.10:53477' threw exception: CHECK failed: IsInitialized(): Can't serialize message of type "mesos.internal.UpdateSlaveMessage" because it is missing required fields: resource_providers.providers[0].resource_version_uuid.value
```
- Mesos Reviewbot Windows
On Aug. 16, 2018, 2:30 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:30 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207553
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68407, 68143, 68144, 68146, 68410, 68147, 68362, 68145]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 17, 2018, 1:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 1:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207510
-----------------------------------------------------------
Fix it, then Ship it!
include/mesos/resource_provider/resource_provider.proto
Lines 42 (patched)
<https://reviews.apache.org/r/68145/#comment290918>
How about adding a short description here? We do the same for the scheduler API.
include/mesos/v1/resource_provider/resource_provider.proto
Lines 42 (patched)
<https://reviews.apache.org/r/68145/#comment290919>
Ditto.
- Chun-Hung Hsiao
On Aug. 17, 2018, 1:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 1:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207615
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68407, 68143, 68144, 68146, 68147, 68362, 68145]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 20, 2018, 9:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 9:52 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207611
-----------------------------------------------------------
PASS: Mesos patch 68145 was successfully built and tested.
Reviews applied: `['68407', '68143', '68144', '68146', '68147', '68362', '68145']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2195/mesos-review-68145
- Mesos Reviewbot Windows
On Aug. 20, 2018, 2:52 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2018, 2:52 a.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/7/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/
-----------------------------------------------------------
(Updated Aug. 20, 2018, 11:52 a.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Add comment.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
In order to allow proper cleanup the resource provider manager sends a
`REMOVED` to a resource provider when it is being removed.
The event is not sent reliably, i.e., if the resource provider was
e.g., not subscribed when it was removed we currently will never
attempt to resend the event.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
src/resource_provider/storage/provider.cpp fc48072aac531bac3cbffc3ba089b8dfa2a2f200
src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
Diff: https://reviews.apache.org/r/68145/diff/7/
Changes: https://reviews.apache.org/r/68145/diff/6-7/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207500
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68407', '68143', '68144', '68146', '68410', '68147', '68362', '68145']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2184/mesos-review-68145
Relevant logs:
- [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2184/mesos-review-68145/logs/mesos-tests.log):
```
I0817 15:07:08.081745 182032 hierarchical.cpp:306] Added framework b824a73a-7a72-4fe8-8862-3276b9234870-0000
E0817 15:07:09.267731 219500 slave.cpp:7269] EXIT with status 1: Failed to perform recovery: Collect failed: Docker ps batch failed Collect failed: Failed to create subprocess 'docker -H npipe:////./pipe/docker_engine inspect mesos-bcd8882f-0760-45d2-a5f6-dfba45bf103e': Failed to call `CreateProcess`: cmd.exe /c "docker -H npipe:////./pipe/docker_engine inspect mesos-bcd8882f-0760-45d2-a5f6-dfba45
d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @0000004773F8BAD0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(3505): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @0000004773F8BDF0.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @000002092858A240.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(247): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @0000020950BF2CC8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @00000209545BC210.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(101): ERROR: this mock object (used in test DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed) should be deleted but never is. Its address is @0000020954622060.
ERROR: 6 leaked mock objects found at program exit.
bf103e" : The paging file is too small for this operation to complete.
If recovery failed due to a change in configuration and you want to
keep the current agent id, you might want to change the
`--reconfiguration_policy` flag to a more permissive value.
To restart this agent with a new agent id instead, do as follows:
rm -f C:\Users\jenkins\AppData\Local\Temp\5tu9om\meta\slaves\latest
This ensures that the agent does not recover old live executors.
If you use the Docker containerizer and think that the Docker
daemon state is broken, you can try to clear it. But be careful:
these commands will erase all containers and images from this host,
not just those started by Mesos!
docker kill $(docker ps -q)
docker rm $(docker ps -a -q)
docker rmi $(docker images -q)
Finally, restart the agent.
```
- Mesos Reviewbot Windows
On Aug. 17, 2018, 1:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 1:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/
-----------------------------------------------------------
(Updated Aug. 17, 2018, 3:53 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
In order to allow proper cleanup the resource provider manager sends a
`REMOVED` to a resource provider when it is being removed.
The event is not sent reliably, i.e., if the resource provider was
e.g., not subscribed when it was removed we currently will never
attempt to resend the event.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
Diff: https://reviews.apache.org/r/68145/diff/6/
Changes: https://reviews.apache.org/r/68145/diff/5-6/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On Aug. 17, 2018, 1:45 a.m., Chun-Hung Hsiao wrote:
> > Seems that we need to update SLRP as well?
Yes, we should think about what we want to do there, see `src/resource_provider/storage/provider.cpp:585ff`.
> On Aug. 17, 2018, 1:45 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 102 (patched)
> > <https://reviews.apache.org/r/68145/diff/5/?file=2073710#file2073710line102>
> >
> > `... when the resource provider is requested to be torn down.`
Does not apply anymore as the message was removed.
> On Aug. 17, 2018, 1:45 a.m., Chun-Hung Hsiao wrote:
> > include/mesos/resource_provider/resource_provider.proto
> > Lines 103 (patched)
> > <https://reviews.apache.org/r/68145/diff/5/?file=2073710#file2073710line103>
> >
> > Do we actually need this message at all?
Removed.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207452
-----------------------------------------------------------
On Aug. 17, 2018, 3:53 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2018, 3:53 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/6/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/#review207452
-----------------------------------------------------------
Seems that we need to update SLRP as well?
include/mesos/resource_provider/resource_provider.proto
Lines 102 (patched)
<https://reviews.apache.org/r/68145/#comment290854>
`... when the resource provider is requested to be torn down.`
include/mesos/resource_provider/resource_provider.proto
Lines 103 (patched)
<https://reviews.apache.org/r/68145/#comment290855>
Do we actually need this message at all?
include/mesos/v1/resource_provider/resource_provider.proto
Lines 102-103 (patched)
<https://reviews.apache.org/r/68145/#comment290856>
Ditto.
src/resource_provider/manager.cpp
Lines 635-637 (patched)
<https://reviews.apache.org/r/68145/#comment290859>
Move this into the then-branch?
src/resource_provider/manager.cpp
Lines 645 (patched)
<https://reviews.apache.org/r/68145/#comment290857>
s/`REMOVED`/`TEARDOWN`/
src/resource_provider/manager.cpp
Lines 650 (patched)
<https://reviews.apache.org/r/68145/#comment290858>
s/`REMOVED`/`TEARDOWN`/
- Chun-Hung Hsiao
On Aug. 16, 2018, 2:30 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68145/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2018, 2:30 p.m.)
>
>
> Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
>
>
> Bugs: MESOS-8403
> https://issues.apache.org/jira/browse/MESOS-8403
>
>
> Repository: mesos
>
>
> Description
> -------
>
> In order to allow proper cleanup the resource provider manager sends a
> `REMOVED` to a resource provider when it is being removed.
>
> The event is not sent reliably, i.e., if the resource provider was
> e.g., not subscribed when it was removed we currently will never
> attempt to resend the event.
>
>
> Diffs
> -----
>
> include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
> include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
> src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
> src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
> src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
>
>
> Diff: https://reviews.apache.org/r/68145/diff/5/
>
>
> Testing
> -------
>
> `make check`
>
> Additional testing with the test case added in https://reviews.apache.org/r/68147/.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 68145: Sent an event to resource providers when
they are removed.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68145/
-----------------------------------------------------------
(Updated Aug. 16, 2018, 4:30 p.m.)
Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.
Changes
-------
Renamed event as suggested by Chun.
Summary (updated)
-----------------
Sent an event to resource providers when they are removed.
Bugs: MESOS-8403
https://issues.apache.org/jira/browse/MESOS-8403
Repository: mesos
Description
-------
In order to allow proper cleanup the resource provider manager sends a
`REMOVED` to a resource provider when it is being removed.
The event is not sent reliably, i.e., if the resource provider was
e.g., not subscribed when it was removed we currently will never
attempt to resend the event.
Diffs (updated)
-----
include/mesos/resource_provider/resource_provider.proto 7c6833378401751a8997ecd3279cf3bf2ad3cbf4
include/mesos/v1/resource_provider/resource_provider.proto 535b898b03cd3d81261d62523916cf9a6410a30d
src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620
src/resource_provider/storage/provider.cpp 22c184f45ea43335c3e1e4598f7409a4f05fb38e
src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8
Diff: https://reviews.apache.org/r/68145/diff/4/
Changes: https://reviews.apache.org/r/68145/diff/3-4/
Testing
-------
`make check`
Additional testing with the test case added in https://reviews.apache.org/r/68147/.
Thanks,
Benjamin Bannier