[GitHub] [skywalking-python] tom-pytel opened a new pull request #104: Fix: BaseExceptions not recorded as errors

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #104:
URL: https://github.com/apache/skywalking-python/pull/104


   Minor change to exception checking on span exit, changed check from `BaseException` to `Exception` so that `KeyboardInterrupt`, `SystemExit` or `GeneratorExit` (even though this should never come back here) are not flagged as errors.
   
   <!-- Uncomment the following checklist WHEN AND ONLY WHEN you're adding a new plugin -->
   <!--
   - [ ] Add a test case for the new plugin
   - [ ] Add a component id in [the main repo](https://github.com/apache/skywalking/blob/master/oap-server/server-bootstrap/src/main/resources/component-libraries.yml#L415)
   - [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
   - [ ] Rebuild the `requirements.txt` by running `tools/env/build_requirements_(linux|windows).sh`
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 merged pull request #104: Fix: BaseExceptions not recorded as errors

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #104:
URL: https://github.com/apache/skywalking-python/pull/104


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org