[GitHub] [spark] HeartSaVioR commented on a change in pull request #25797: [SPARK-29043][Core] Improve the concurrent performance of History Server

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #25797: [SPARK-29043][Core] Improve the concurrent performance of History Server
URL: https://github.com/apache/spark/pull/25797#discussion_r329847497
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala
 ##########
 @@ -561,7 +555,7 @@ private[history] class FsHistoryProvider(conf: SparkConf, clock: Clock)
         .last(newLastScanTime - 1)
         .asScala
         .toList
-      stale.foreach { log =>
+      stale.filterNot(isProcessing(_)).foreach { log =>
 
 Review comment:
   Is it safe if "cleaner task" and "replay task" access the same log directory concurrently? I guess we still need to filter these logs for safety, but we need to also retry cleaning up these logs sooner, at least sooner than the interval of cleaner.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org