You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Erik Hatcher (JIRA)" <ji...@apache.org> on 2007/01/16 01:44:27 UTC
[jira] Resolved: (SOLR-108) Some basic clean up and validation for
Solr::Request::Standard
[ https://issues.apache.org/jira/browse/SOLR-108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Erik Hatcher resolved SOLR-108.
-------------------------------
Resolution: Fixed
Assignee: Erik Hatcher
Applied, thanks. I did have to add if conditions on the start/rows setting to get the functional test to pass, as rows became zero in your patch instead of nil.
> Some basic clean up and validation for Solr::Request::Standard
> --------------------------------------------------------------
>
> Key: SOLR-108
> URL: https://issues.apache.org/jira/browse/SOLR-108
> Project: Solr
> Issue Type: Improvement
> Components: clients - ruby - flare
> Environment: Darwin rocket 8.8.1 Darwin Kernel Version 8.8.1: Mon Sep 25 19:42:00 PDT 2006; root:xnu-792.13.8.obj~1/RELEASE_I386 i386 i386
> Reporter: William Groppe
> Assigned To: Erik Hatcher
> Priority: Minor
> Attachments: request_standard.patch
>
>
> This is a slightly different approach from the one you took. If we get a hash in, and we want a hash out, why convert it to instance variables? This could even be taken a step further, why not create the hash that solr will need on initialization? Anyway, it does some basic validation, and passes all tests.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira