You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/22 23:07:04 UTC
[GitHub] [camel] claudio4j opened a new pull request, #7855: CAMEL-18218 Fix camel-jira not adding components field
claudio4j opened a new pull request, #7855:
URL: https://github.com/apache/camel/pull/7855
* the "components" field was not updated due to a bug in handling the field
* Added tests for the component field
* Fixed the "components" field description
* Updated google-guava accordingly to jira-rest-java-client-parent
https://issues.apache.org/jira/browse/CAMEL-18218
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1163782206
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] orpiske commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
orpiske commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1163914423
> `main pr build / build (11) (pull_request)` fails with `Error: Process completed with exit code 1.` but I couldn't find the error file.
Thanks for your contribution!
Unfortunately the org restrictions don't allow public access to the log files, so we upload them on request. I have done that for you.
[test-logs.zip](https://github.com/apache/camel/files/8963765/test-logs.zip)
It's a checkstyle issue. You can usually fix those by running the auto format with `mvn -Pformat,fastinstall install`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1164490890
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus merged pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
davsclaus merged PR #7855:
URL: https://github.com/apache/camel/pull/7855
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1164481265
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] claudio4j commented on a diff in pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
claudio4j commented on code in PR #7855:
URL: https://github.com/apache/camel/pull/7855#discussion_r905041067
##########
components/camel-jira/src/main/java/org/apache/camel/component/jira/producer/AddIssueProducer.java:
##########
@@ -25,6 +27,7 @@
import com.atlassian.jira.rest.client.api.domain.IssueType;
import com.atlassian.jira.rest.client.api.domain.Priority;
import com.atlassian.jira.rest.client.api.domain.input.IssueInputBuilder;
+import com.google.common.base.Strings;
Review Comment:
Fixed that, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7855:
URL: https://github.com/apache/camel/pull/7855#discussion_r904513242
##########
components/camel-jira/src/main/java/org/apache/camel/component/jira/producer/AddIssueProducer.java:
##########
@@ -25,6 +27,7 @@
import com.atlassian.jira.rest.client.api.domain.IssueType;
import com.atlassian.jira.rest.client.api.domain.Priority;
import com.atlassian.jira.rest.client.api.domain.input.IssueInputBuilder;
+import com.google.common.base.Strings;
Review Comment:
Do not use google/guava for this - Camel has API for checking if a string is empty, or since Camel is now Java 11 based, you can use blank() method on Strings from the JDK itself
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1164506817
:heavy_check_mark: Finished component verification: 0 component(s) test failed out of **2 component(s) tested**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] claudio4j commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1163800372
`main pr build / build (11) (pull_request)` fails with `Error: Process completed with exit code 1.` but I couldn't find the error file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] davsclaus commented on a diff in pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
davsclaus commented on code in PR #7855:
URL: https://github.com/apache/camel/pull/7855#discussion_r904644878
##########
components/camel-jira/src/main/java/org/apache/camel/component/jira/producer/AddIssueProducer.java:
##########
@@ -25,6 +27,7 @@
import com.atlassian.jira.rest.client.api.domain.IssueType;
import com.atlassian.jira.rest.client.api.domain.Priority;
import com.atlassian.jira.rest.client.api.domain.input.IssueInputBuilder;
+import com.google.common.base.Strings;
Review Comment:
org.apache.camel.util.ObjectHelper isEmpty method
As we need to backport to 3.14.x then we cannot use Java 11 APIs as 3.14 supports JDK8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] claudio4j commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
claudio4j commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1164430456
I will backport to 3.14 branch, thanks for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1163745410
:warning: This PR changes Camel components and will be tested automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel] github-actions[bot] commented on pull request #7855: CAMEL-18218 Fix camel-jira not adding components field
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7855:
URL: https://github.com/apache/camel/pull/7855#issuecomment-1163775698
:x: Finished component verification: **1 component(s) test failed** out of 1 component(s) tested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org