You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "Flavio Junqueira (Created) (JIRA)" <ji...@apache.org> on 2011/11/17 14:50:54 UTC

[jira] [Created] (BOOKKEEPER-113) NPE In BookKeeper test

NPE In BookKeeper test
----------------------

                 Key: BOOKKEEPER-113
                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
             Project: Bookkeeper
          Issue Type: Bug
            Reporter: Flavio Junqueira
            Priority: Minor


This is not correctness issue, but it is ugly to throw an NPE there. 

{noformat}
Running org.apache.bookkeeper.test.BookieFailureTest
Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
WARNING: An exception was thrown by ChannelFutureListener.
java.lang.NullPointerException
	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
	at java.lang.Thread.run(Thread.java:680)
{noformat}

The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13215852#comment-13215852 ] 

Hudson commented on BOOKKEEPER-113:
-----------------------------------

Integrated in bookkeeper-trunk #377 (See [https://builds.apache.org/job/bookkeeper-trunk/377/])
    BOOKKEEPER-113: NPE In BookKeeper test (fpj via ivank) (Revision 1293383)

     Result = ABORTED
ivank : 
Files : 
* /zookeeper/bookkeeper/trunk/CHANGES.txt
* /zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java

                
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch, BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214507#comment-13214507 ] 

Ivan Kelly commented on BOOKKEEPER-113:
---------------------------------------

I think the current approach is good, but the catch should be broader (Throwable).
                
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Flavio Junqueira (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-113:
----------------------------------------

    Attachment: BOOKKEEPER-113.patch
    
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Ivan Kelly (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211749#comment-13211749 ] 

Ivan Kelly commented on BOOKKEEPER-113:
---------------------------------------

why not just check for null? If I remember correctly, it's the getBufferFactory() which is returning it.
                
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Ivan Kelly (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ivan Kelly updated BOOKKEEPER-113:
----------------------------------

    Fix Version/s: 4.1.0
    
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Ivan Kelly
>            Priority: Minor
>             Fix For: 4.1.0
>
>         Attachments: BOOKKEEPER-113.patch, BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Flavio Junqueira (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13211752#comment-13211752 ] 

Flavio Junqueira commented on BOOKKEEPER-113:
---------------------------------------------

In that long call chain, it looks like there are multiple places where we can get an NPE from. Also, checking for null and executing the operation are not atomic, so it can still break. That's my rationale at least...
                
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Flavio Junqueira (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira updated BOOKKEEPER-113:
----------------------------------------

    Attachment: BOOKKEEPER-113.patch

Made it catch Throwable.
                
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch, BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (BOOKKEEPER-113) NPE In BookKeeper test

Posted by "Flavio Junqueira (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/BOOKKEEPER-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Flavio Junqueira reassigned BOOKKEEPER-113:
-------------------------------------------

    Assignee: Flavio Junqueira
    
> NPE In BookKeeper test
> ----------------------
>
>                 Key: BOOKKEEPER-113
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-113
>             Project: Bookkeeper
>          Issue Type: Bug
>            Reporter: Flavio Junqueira
>            Assignee: Flavio Junqueira
>            Priority: Minor
>         Attachments: BOOKKEEPER-113.patch
>
>
> This is not correctness issue, but it is ugly to throw an NPE there. 
> {noformat}
> Running org.apache.bookkeeper.test.BookieFailureTest
> Nov 17, 2011 2:48:28 PM org.jboss.netty.channel.DefaultChannelFuture
> WARNING: An exception was thrown by ChannelFutureListener.
> java.lang.NullPointerException
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient.addEntry(PerChannelBookieClient.java:231)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:85)
> 	at org.apache.bookkeeper.proto.BookieClient$1.operationComplete(BookieClient.java:78)
> 	at org.apache.bookkeeper.proto.PerChannelBookieClient$1.operationComplete(PerChannelBookieClient.java:158)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListener(DefaultChannelFuture.java:381)
> 	at org.jboss.netty.channel.DefaultChannelFuture.notifyListeners(DefaultChannelFuture.java:372)
> 	at org.jboss.netty.channel.DefaultChannelFuture.setSuccess(DefaultChannelFuture.java:316)
> 	at org.jboss.netty.channel.socket.nio.NioWorker$RegisterTask.run(NioWorker.java:767)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.processRegisterTaskQueue(NioWorker.java:256)
> 	at org.jboss.netty.channel.socket.nio.NioWorker.run(NioWorker.java:198)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
> 	at java.lang.Thread.run(Thread.java:680)
> {noformat}
> The fix should be trivial, though.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira