[GitHub] spark pull request #16405: [SPARK-19002][BUILD][PYTHON] Check pep8 against a...

[holdenk <gi...@git.apache.org>]

Github user holdenk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16405#discussion_r94259548
  
    --- Diff: dev/lint-python ---
    @@ -19,10 +19,8 @@
     
     SCRIPT_DIR="$( cd "$( dirname "$0" )" && pwd )"
     SPARK_ROOT_DIR="$(dirname "$SCRIPT_DIR")"
    -PATHS_TO_CHECK="./python/pyspark/ ./examples/src/main/python/ ./dev/sparktestsupport"
    -# TODO: fix pep8 errors with the rest of the Python scripts under dev
    -PATHS_TO_CHECK="$PATHS_TO_CHECK ./dev/run-tests.py ./python/*.py ./dev/run-tests-jenkins.py"
    -PATHS_TO_CHECK="$PATHS_TO_CHECK ./dev/pip-sanity-check.py"
    +# Exclude auto-geneated configuration file.
    +PATHS_TO_CHECK="$( find "$SPARK_ROOT_DIR" -name "*.py" -not -path "*python/docs/conf.py" )"
    --- End diff --
    
    I'm slightly concerned we might eventually have this be too long to pass in the shell (on Linux in bash ARG_MAX is pretty high but that's not the case everywhere, although we would probably have to double the number of Python files before this started being an issue in Cygwin).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org