You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by TanaseButcaru <gi...@git.apache.org> on 2016/02/13 16:38:50 UTC
[GitHub] cordova-plugin-media-capture pull request: Fix MediaFile.getFormat...
GitHub user TanaseButcaru opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/53
Fix MediaFile.getFormatData on Android (readded)
JIRA Issue [CB-10488](https://issues.apache.org/jira/browse/CB-10488)
JIRA Issue [CB-10489](https://issues.apache.org/jira/browse/CB-10489)
Also resolves this one #43 / [CB-9611](https://issues.apache.org/jira/browse/CB-9611)
-------------
1. ``getFormatData`` was not working at all on Android (and iOS) because it was using the ``localURL`` instead of ``fullPath``
2. audio recording was not even checking for metadata because the current code is only searching for .3gpp audio files, but the default recording file type for android is ``audio/amr``.
On my android 4.4, the Sound Recorder app has options from where the user can change the output file type (it has wav, amr & 3gpp); some devices are recording aac too.
All these file types for audio recording are now supported.
3. Related CB-9611 (PR#43) resolved without hardcoded ``file://`` string.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TanaseButcaru/cordova-plugin-media-capture-unofficial MediaFile-getFormat-20160213
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-media-capture/pull/53.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #53
----
commit 988cad058e14ec8518902d52baae447409aaa20e
Author: TanaseButcaru <co...@butcaru.com>
Date: 2016-01-31T22:42:07Z
Fix for MediaFile.getFormatData
commit e8b7fc5e6f5c4d4077646847999daaccba6f852d
Author: TanaseButcaru <co...@butcaru.com>
Date: 2016-02-03T21:49:06Z
Fix for MediaFile.getFormatData / audio recording support
commit 5fb509da851ccb2bc320776fa037975a365b80ed
Author: Tanase Butcaru <ta...@users.noreply.github.com>
Date: 2016-02-12T09:20:43Z
Merge pull request #1 from apache/master
chore: edit package.json license to match SPDX id
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #53: [CB-10488][CB-10489][CB-9611] Fix Me...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/53
Tested and confirm, it works well. Also there is a couple of manual tests added for this in 7e28e9cb1d60e54ecb1e29e61d38329d9c0e62f0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request: [CB-10488][CB-10489][CB...
Posted by cordova-qa <gi...@git.apache.org>.
Github user cordova-qa commented on the pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/53#issuecomment-218631729
Cordova CI Build has one or more failures.
**Dashboard** - http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2/
**Results**
1. [Windows 8.1 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-store/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-store/artifact/)
2. [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//80/label=windows-slave,platformName=windows-10-store/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-10-store/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-10-store/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-10-store/artifact/)
3. [Windows 8.1 Phone]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-phone/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-phone/) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-phone/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=windows-8.1-phone/artifact/)
4. [iOS]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=ios/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=ios/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=ios/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=ios/artifact/)
5. [Android Mac]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=android/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=android/) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=android/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=mac-slave,platformName=android/artifact/)
6. [Android Windows]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=android/) - [Console Output]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=android/console) - [Test Results]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=android/testReport/) - [Build Artifacts]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-media-capture/2//label=windows-slave,platformName=android/artifact/)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture pull request #53: [CB-10488][CB-10489][CB-9611]...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-media-capture/pull/53
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-media-capture issue #53: [CB-10488][CB-10489][CB-9611] Fix Me...
Posted by mnutkiewicz <gi...@git.apache.org>.
Github user mnutkiewicz commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/53
Tested the fix for (1) on my app using a 6S and can confirm this solves this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org