You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/10/31 12:21:48 UTC
[GitHub] carbondata pull request #2887: [HOTFIX] Throw original exception in thread p...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2887
[HOTFIX] Throw original exception in thread pool
If there are exception occurs in the Callable.run in the thread pool, it should throw the original exception instead of throw a new one, which makes it hard for debugging.
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
Please provide details on
- Whether new unit test cases have been added or why no new tests are required?
- How it is tested? Please attach test report.
- Is it a performance related change? Please attach the performance test report.
- Any additional information to help reviewers in testing this change.
rerun all test
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata eat_exception
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2887.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2887
----
----
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1431/
---
[GitHub] carbondata pull request #2887: [HOTFIX] Throw original exception in thread p...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2887#discussion_r229671196
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java ---
@@ -131,15 +130,15 @@ public CarbonFactDataHandlerModel getDataHandlerModel() {
for (int j = 0; j < rangeExecutorServiceSubmitList.size(); j++) {
rangeExecutorServiceSubmitList.get(j).get();
}
- } catch (InterruptedException | ExecutionException e) {
+ } catch (InterruptedException e) {
throw new CarbonDataWriterException(e);
+ } catch (ExecutionException e) {
+ throw new CarbonDataWriterException(e.getCause());
--- End diff --
Here we get the exception in the thread by e.getCause
---
[GitHub] carbondata pull request #2887: [HOTFIX] Throw original exception in thread p...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2887#discussion_r229670798
--- Diff: processing/src/main/java/org/apache/carbondata/processing/loading/steps/DataWriterProcessorStepImpl.java ---
@@ -222,41 +220,24 @@ public void finish(CarbonFactHandler dataHandler) {
System.currentTimeMillis());
}
- private void processingComplete(CarbonFactHandler dataHandler) throws CarbonDataLoadingException {
+ private void processingComplete(CarbonFactHandler dataHandler) {
if (null != dataHandler) {
- try {
- dataHandler.closeHandler();
- } catch (CarbonDataWriterException e) {
- LOGGER.error(e.getMessage(), e);
- throw new CarbonDataLoadingException(e.getMessage(), e);
- } catch (Exception e) {
- LOGGER.error(e.getMessage(), e);
- throw new CarbonDataLoadingException("There is an unexpected error: " + e.getMessage());
--- End diff --
Earlier here is the problem, we eat the original exception
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9455/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1216/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1447/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2887
retest this please
---
[GitHub] carbondata pull request #2887: [HOTFIX] Throw original exception in thread p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2887
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2887
retest this please
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Failed with Spark 2.2.1, Please check CI http://95.216.28.178:8080/job/ApacheCarbonPRBuilder1/1411/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1232/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder2.1/1194/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9480/
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on the issue:
https://github.com/apache/carbondata/pull/2887
LGTM
---
[GitHub] carbondata issue #2887: [HOTFIX] Throw original exception in thread pool
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2887
Build Success with Spark 2.3.1, Please check CI http://136.243.101.176:8080/job/carbondataprbuilder2.3/9496/
---