You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@thrift.apache.org by GitBox <gi...@apache.org> on 2021/05/06 20:13:16 UTC

[GitHub] [thrift] bluezio commented on pull request #2378: THRIFT-5400: Add the .annotation package to Export-Package

bluezio commented on pull request #2378:
URL: https://github.com/apache/thrift/pull/2378#issuecomment-833828957


   This change is needed to allow Eclipse to consume the Java library for Thrift as an OSGi bundle. Without that directive, Eclipse will give an error on the Java code generated by the Thrift compiler, saying that the `@Nullable` annotation is not API (as the package which contains it is not exported). This also fails Eclipse Tycho builds of Thrift-generated code (Tycho allows for building Eclipse plugins from a CI environment using Maven).
   
   In other words, the OSGi metadata for the Java Thrift library was not updated when the .annotation package and its `@Nullable` was added in a prior release, and Eclipse refuses to compile code using the Java Thrift library because of this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org