You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/05/09 10:54:31 UTC
Re: Review Request 58179: For sort/partition operator,
if there is only 1 reducer, display just "sort" rather than "sort/partition"
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
-----------------------------------------------------------
(Updated May 9, 2017, 10:54 a.m.)
Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673
Repository: ambari
Description
-------
Now when we have only one reducer, the label for aort/partition will be displayed as partition.
Diffs
-----
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15
Diff: https://reviews.apache.org/r/58179/diff/1/
Testing
-------
Manual testing done
File Attachments (updated)
----------------
This patch contains code which should go along with other patch
https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch
Thanks,
venkat sairam
Re: Review Request 58179: For sort/partition operator,
if there is only 1 reducer, display just "sort" rather than "sort/partition"
Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/#review174309
-----------------------------------------------------------
Ship it!
Ship It!
- Prabhjyot Singh
On May 9, 2017, 8 p.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58179/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 8 p.m.)
>
>
> Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20673
> https://issues.apache.org/jira/browse/AMBARI-20673
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Now when we have only one reducer, the label for aort/partition will be displayed as partition.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js d0a3e0b
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 9dbbb00
>
>
> Diff: https://reviews.apache.org/r/58179/diff/2/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> Thanks,
>
> venkat sairam
>
>
Re: Review Request 58179: For sort/partition operator,
if there is only 1 reducer, display just "sort" rather than "sort/partition"
Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/
-----------------------------------------------------------
(Updated May 9, 2017, 2:30 p.m.)
Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
Bugs: AMBARI-20673
https://issues.apache.org/jira/browse/AMBARI-20673
Repository: ambari
Description
-------
Now when we have only one reducer, the label for aort/partition will be displayed as partition.
Diffs (updated)
-----
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js d0a3e0b
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js 9dbbb00
Diff: https://reviews.apache.org/r/58179/diff/2/
Changes: https://reviews.apache.org/r/58179/diff/1-2/
Testing
-------
Manual testing done
Thanks,
venkat sairam
Re: Review Request 58179: For sort/partition operator,
if there is only 1 reducer, display just "sort" rather than "sort/partition"
Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58179/#review174306
-----------------------------------------------------------
Ship it!
Ship It!
- belliraj hb
On May 9, 2017, 10:54 a.m., venkat sairam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58179/
> -----------------------------------------------------------
>
> (Updated May 9, 2017, 10:54 a.m.)
>
>
> Review request for Ambari, Abhishek Kumar, Gaurav Nagar, Nitiraj Rathore, Padma Priya N, Pallav Kulshreshtha, and Rohit Choudhary.
>
>
> Bugs: AMBARI-20673
> https://issues.apache.org/jira/browse/AMBARI-20673
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Now when we have only one reducer, the label for aort/partition will be displayed as partition.
>
>
> Diffs
> -----
>
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 1cfcb15
>
>
> Diff: https://reviews.apache.org/r/58179/diff/1/
>
>
> Testing
> -------
>
> Manual testing done
>
>
> File Attachments
> ----------------
>
> This patch contains code which should go along with other patch
> https://reviews.apache.org/media/uploaded/files/2017/05/09/0c59f3e2-aedf-4893-9214-be56628dcbef__AMBARI-20673-trunk.01.patch
>
>
> Thanks,
>
> venkat sairam
>
>