You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/18 05:23:43 UTC

[GitHub] [airflow] ktrueda opened a new pull request #11627: Add D205 pydocstyle check

ktrueda opened a new pull request #11627:
URL: https://github.com/apache/airflow/pull/11627


   Enabled D205 Pydocstyle check
   
     - Fixed all pre-commit errors
   
   Part of issue: #10742


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718777324


   CI is sad. I working on fix. 
   ```
   black.............................................................................................................................Failed
   - hook id: black
   - files were modified by this hook
   
   reformatted /home/runner/work/airflow/airflow/airflow/providers/slack/operators/slack.py
   All done! ✨ 🍰 ✨
   1 file reformatted, 1558 files left unchanged.
   ```
   ```
   All changes made by hooks:
   diff --git a/airflow/providers/slack/operators/slack.py b/airflow/providers/slack/operators/slack.py
   index 18bc86f..29b53cf 100644
   --- a/airflow/providers/slack/operators/slack.py
   +++ b/airflow/providers/slack/operators/slack.py
   @@ -90,7 +90,7 @@ class SlackAPIOperator(BaseOperator):
            slack.call(self.method, json=self.api_params)
    
    
   -class SlackAPIPostOperator(SlackAPIOperator):   # noqa: D412
   +class SlackAPIPostOperator(SlackAPIOperator):  # noqa: D412
        """
        Posts messages to a slack channel.
    
   @@ -160,7 +160,7 @@ class SlackAPIPostOperator(SlackAPIOperator):   # noqa: D412
            }
    
    
   -class SlackAPIFileOperator(SlackAPIOperator):   # noqa: D412
   +class SlackAPIFileOperator(SlackAPIOperator):  # noqa: D412
        """
        Send a file to a slack channel
    
   Error: Process completed with exit code 1.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil edited a comment on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718733042


   @ktrueda I have rebased on master, resolved the merge conflicts, squashed the commits, pushed a fix. Let's see what the CI says.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] removed a comment on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714441759






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r507729670



##########
File path: airflow/cli/commands/task_command.py
##########
@@ -220,6 +221,8 @@ def task_run(args, dag=None):
 @cli_utils.action_logging
 def task_failed_deps(args):
     """
+    task_failed_deps.

Review comment:
       Thank you 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715675079


   @potiuk 
   I tried rebase, but it doesn't work.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718807733


   [The Workflow run](https://github.com/apache/airflow/actions/runs/336046055) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-713519726


   [The Workflow run](https://github.com/apache/airflow/actions/runs/319791151) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-728264922


   > @kaxil
   > If my code is bad, please suggest.
   > Or I'll close this PR.
   
   Thanks @ktrueda , I am on leave today, will check back once I am back


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511460824



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -89,9 +92,9 @@ def execute(self, **kwargs):  # noqa: D403
 
 class SlackAPIPostOperator(SlackAPIOperator):
     """
-    Posts messages to a slack channel
-    Examples:
+    Posts messages to a slack channel.
 
+    Examples:
     .. code-block:: python

Review comment:
       Tests is failing because of this, a space is needed here I think
   
   ```suggestion
       Examples:
   
       .. code-block:: python
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-712792948


   [The Workflow run](https://github.com/apache/airflow/actions/runs/317554300) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] closed pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #11627:
URL: https://github.com/apache/airflow/pull/11627


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] removed a comment on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718807103


   [The Workflow run](https://github.com/apache/airflow/actions/runs/336028400) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718733042


   @ktrueda I have rebased on master, resolved the merge conflicts, pushed a fix. Let's see what the CI says.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-721718250


   [The Workflow run](https://github.com/apache/airflow/actions/runs/345559772) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715927679


   @kaxil 
   Thank you for your suggestion very much!!
   
   πŸ™ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511461221



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -159,8 +162,8 @@ def construct_api_call_params(self) -> Any:
 class SlackAPIFileOperator(SlackAPIOperator):
     """
     Send a file to a slack channel
-    Examples:
 
+    Examples:
     .. code-block:: python

Review comment:
       ```suggestion
       Examples:
   
       .. code-block:: python
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r507729221



##########
File path: airflow/__init__.py
##########
@@ -18,9 +18,9 @@
 #
 
 """
-Authentication is implemented using flask_login and different environments can
-implement their own login mechanisms by providing an `airflow_login` module
-in their PYTHONPATH. airflow_login should be based off the
+Authentication is implemented using flask_login and different environments can implement their own login mechanisms by providing an `airflow_login` module in their PYTHONPATH.
+
+airflow_login should be based off the
 `airflow.www.login`

Review comment:
       Thank you. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-719112693


   @kaxil @mik-laj 
   Thank you for fixing very much.
   I'll fix dummy summary heading.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r514320069



##########
File path: airflow/models/dag.py
##########
@@ -525,6 +531,8 @@ def next_dagrun_info(
 
     def next_dagrun_after_date(self, date_last_automated_dagrun: Optional[pendulum.DateTime]):
         """
+        next_dagrun_after_date

Review comment:
       It looks unrelated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715450018


   [The Workflow run](https://github.com/apache/airflow/actions/runs/324442240) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714488458


   [The Workflow run](https://github.com/apache/airflow/actions/runs/322103166) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r514332693



##########
File path: airflow/models/dag.py
##########
@@ -388,6 +390,8 @@ def __exit__(self, _type, _value, _tb):
     @staticmethod
     def _upgrade_outdated_dag_access_control(access_control=None):
         """
+        _upgrade_outdated_dag_access_control

Review comment:
       We should not be adding a dummy Summary heading for docstring @ktrueda 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-716101639


   [The Workflow run](https://github.com/apache/airflow/actions/runs/326961589) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj edited a comment on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718798486


   Spell check is sad now. :-/
   ```
   _api/airflow/models/dag/index.rst:1109: (parametrize)  Accepts kwargs for operator kwarg. Can be used to parametrize DAGs.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715450419






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r507734478



##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -46,6 +46,8 @@
 
 class GunicornMonitor(LoggingMixin):
     """
+    GunicornMonitor
+

Review comment:
       The existing first paragraph was good. But it's long as a first line summary .
   Obeying D205 and E501 summary line needs to obey two rules.
   - only 1 line (not 2+ line)
   - length < 110




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714716484


   I believe it was a merge of a change that failed the static checks -  it is already fixed by https://github.com/apache/airflow/commit/95be3eec42cd5ae0ef8c6402f7d1cd87e5d93848 and  you need to rebase to latest master to fix it (that's what I did with my PRs)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714441412


   [The Workflow run](https://github.com/apache/airflow/actions/runs/321952645) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715329229


   @potiuk 
   Thank you for your advice!!!
   I rebased it and pushed it.
   
   πŸ™ 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-711457606


   Static checks are failing::
   
   
   ```
   
   airflow/providers/amazon/aws/sensors/step_function_execution.py:28:111: E501 line too long (118 > 110 characters)
   airflow/jobs/backfill_job.py:290:111: E501 line too long (142 > 110 characters)
   airflow/jobs/backfill_job.py:711:111: E501 line too long (122 > 110 characters)
   airflow/jobs/backfill_job.py:768:111: E501 line too long (129 > 110 characters)
   airflow/jobs/backfill_job.py:847:111: E501 line too long (147 > 110 characters)
   airflow/providers/amazon/aws/example_dags/example_google_api_to_s3_transfer_advanced.py:18:111: E501 line too long (167 > 110 characters)
   airflow/operators/generic_transfer.py:27:111: E501 line too long (124 > 110 characters)
   airflow/providers/google/cloud/hooks/kubernetes_engine.py:89:111: E501 line too long (124 > 110 characters)
   airflow/providers/exasol/hooks/exasol.py:178:111: E501 line too long (120 > 110 characters)
   airflow/settings.py:127:111: E501 line too long (161 > 110 characters)
   airflow/providers/google/suite/transfers/gcs_to_gdrive.py:35:111: E501 line too long (115 > 110 characters)
   airflow/providers/amazon/aws/hooks/batch_client.py:239:111: E501 line too long (116 > 110 characters)
   airflow/providers/amazon/aws/hooks/batch_client.py:282:111: E501 line too long (129 > 110 characters)
   airflow/providers/http/sensors/http.py:29:111: E501 line too long (123 > 110 characters)
   airflow/providers/amazon/aws/hooks/s3.py:47:111: E501 line too long (132 > 110 characters)
   airflow/jobs/scheduler_job.py:552:111: E501 line too long (131 > 110 characters)
   airflow/jobs/scheduler_job.py:939:111: E501 line too long (122 > 110 characters)
   airflow/jobs/scheduler_job.py:1193:111: E501 line too long (116 > 110 characters)
   airflow/jobs/scheduler_job.py:1564:111: E501 line too long (146 > 110 characters)
   airflow/jobs/scheduler_job.py:1776:111: E501 line too long (130 > 110 characters)
   airflow/providers/google/cloud/transfers/bigquery_to_mysql.py:31:111: E501 line too long (131 > 110 characters)
   airflow/providers/amazon/aws/operators/glue.py:30:111: E501 line too long (112 > 110 characters)
   airflow/configuration.py:56:111: E501 line too long (139 > 110 characters)
   airflow/configuration.py:230:111: E501 line too long (122 > 110 characters)
   airflow/providers/amazon/aws/example_dags/example_imap_attachment_to_s3.py:19:111: E501 line too long (144 > 110 characters)
   airflow/providers/google/cloud/hooks/functions.py:61:111: E501 line too long (117 > 110 characters)
   airflow/utils/log/colored_log.py:43:111: E501 line too long (140 > 110 characters)
   airflow/example_dags/example_branch_python_dop_operator_3.py:20:111: E501 line too long (141 > 110 characters)
   airflow/providers/google/cloud/operators/gcs.py:283:111: E501 line too long (134 > 110 characters)
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-712284909


   [The Workflow run](https://github.com/apache/airflow/actions/runs/315892182) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714492687


   `CI Build / Build docs (pull_request) Failing after 10m β€” Build docs` said
   
   ```
   ==================== Error   1 ====================
    WARNING: Definition list ends without a blank line; unexpected unindent.
   
   File path: /opt/airflow/docs/_api/airflow/providers/slack/operators/slack/index.rst (71)
   
     67 |            dag=dag,
     68 |            token="XXX",
     69 |            text="hello there!",
     70 |            channel="#random",
     71 |        )
     72 | 
     73 |    :param channel: channel in which to post message on slack name (#general) or
     74 |        ID (C12318391). (templated)
     75 |    :type channel: str
     76 |    :param username: Username that airflow will be posting to Slack as. (templated)
   ==================== Error   2 ====================
    WARNING: Definition list ends without a blank line; unexpected unindent.
   
   File path: /opt/airflow/docs/_api/airflow/providers/slack/operators/slack/index.rst (123)
   
    119 |            initial_comment="Hello World!",
    120 |            filename="hello_world.csv",
    121 |            filetype="csv",
    122 |            content="hello,world,csv,file",
    123 |        )
    124 | 
    125 |    :param channel: channel in which to sent file on slack name (templated)
    126 |    :type channel: str
    127 |    :param initial_comment: message to send to slack. (templated)
    128 |    :type initial_comment: str
   ==================================================
   ```
   
   `CI Build / Spell check docs (pull_request)` said
   
   ```
   /opt/airflow/docs/_api/airflow/providers/slack/operators/slack/index.rst:71:Definition list ends without a blank line; unexpected unindent.
   ==================== Error   1 ====================
   Sphinx spellcheck returned non-zero exit status: 2.
   
   ==================================================
   ```
   
   I didn't modify these files. How can I pass these CI.
   
   And `CI Build / MySQL8, Py3.6 (pull_request)` failed. I have no idea about this test.
   
   
   
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-717976564


   @kaxil 
   https://github.com/apache/airflow/pull/11627#discussion_r511490113
   If you have any solution, please let me know it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-713047293


   [The Workflow run](https://github.com/apache/airflow/actions/runs/318245926) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715450883


   [The Workflow run](https://github.com/apache/airflow/actions/runs/324498487) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-713133192


   Static checks are sad.
   ```
   airflow/kubernetes/kube_client.py:69 in private function `_enable_tcp_keepalive`:
           D205: 1 blank line required between summary line and description (found 0)
   airflow/providers/discord/operators/discord_webhook.py:28 in public class `DiscordWebhookOperator`:
           D205: 1 blank line required between summary line and description (found 0)
   airflow/providers/google/cloud/operators/bigquery_dts.py:199 in public class `BigQueryDataTransferServiceStartTransferRunsOperator`:
           D205: 1 blank line required between summary line and description (found 0)
   airflow/providers/microsoft/azure/operators/azure_cosmos.py:25 in public class `AzureCosmosInsertDocumentOperator`:
           D205: 1 blank line required between summary line and description (found 0)
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511490113



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -89,9 +92,9 @@ def execute(self, **kwargs):  # noqa: D403
 
 class SlackAPIPostOperator(SlackAPIOperator):
     """
-    Posts messages to a slack channel
-    Examples:
+    Posts messages to a slack channel.
 
+    Examples:
     .. code-block:: python

Review comment:
       Don't worry, I will check back later tonight or tomorrow and we will figure out a solution, you have done an amazing job with this PR, thanks.
   
   
   Btw there are some conflicts, can you rebase on the lastest master please




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718807103


   [The Workflow run](https://github.com/apache/airflow/actions/runs/336028400) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718798486


   Spell checks are sad now. :-/
   ```
   _api/airflow/models/dag/index.rst:1109: (parametrize)  Accepts kwargs for operator kwarg. Can be used to parametrize DAGs.
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715760981


   [The Workflow run](https://github.com/apache/airflow/actions/runs/325528369) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-727933168


   @kaxil 
   If my code is bad, please suggest. 
   Or I'll close this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714441759


   [The Workflow run](https://github.com/apache/airflow/actions/runs/321959801) is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks$,^Build docs$,^Spell check docs$,^Backport packages$,^Checks: Helm tests$,^Test OpenAPI*.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r514320352



##########
File path: airflow/models/dag.py
##########
@@ -810,6 +817,8 @@ def normalized_schedule_interval(self) -> Optional[ScheduleInterval]:
     @provide_session
     def handle_callback(self, dagrun, success=True, reason=None, session=None):
         """
+        handle_callback

Review comment:
       It looks unrelated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ashb commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r507597027



##########
File path: airflow/__init__.py
##########
@@ -18,9 +18,9 @@
 #
 
 """
-Authentication is implemented using flask_login and different environments can
-implement their own login mechanisms by providing an `airflow_login` module
-in their PYTHONPATH. airflow_login should be based off the
+Authentication is implemented using flask_login and different environments can implement their own login mechanisms by providing an `airflow_login` module in their PYTHONPATH.

Review comment:
       This line is too long. Please wrap at 110 characters.

##########
File path: airflow/__init__.py
##########
@@ -18,9 +18,9 @@
 #
 
 """
-Authentication is implemented using flask_login and different environments can
-implement their own login mechanisms by providing an `airflow_login` module
-in their PYTHONPATH. airflow_login should be based off the
+Authentication is implemented using flask_login and different environments can implement their own login mechanisms by providing an `airflow_login` module in their PYTHONPATH.
+
+airflow_login should be based off the
 `airflow.www.login`

Review comment:
       ```suggestion
   airflow_login should be based off the ``airflow.www.login``
   ```

##########
File path: airflow/cli/commands/task_command.py
##########
@@ -220,6 +221,8 @@ def task_run(args, dag=None):
 @cli_utils.action_logging
 def task_failed_deps(args):
     """
+    task_failed_deps.

Review comment:
       ```suggestion
       List which dependencies are failing (stopping execution) for a given TaskInstance.
   ```

##########
File path: airflow/configuration.py
##########
@@ -228,8 +227,8 @@ def _validate(self):
 
     def _validate_config_dependencies(self):
         """
-        Validate that config values aren't invalid given other config values
-        or system-level limitations and requirements.
+        Validate that config values aren't invalid given other config values or system-level limitations and requirements.
+

Review comment:
       Previous form was fine/correct.

##########
File path: airflow/example_dags/example_branch_python_dop_operator_3.py
##########
@@ -17,8 +17,7 @@
 # under the License.
 
 """
-Example DAG demonstrating the usage of BranchPythonOperator with depends_on_past=True, where tasks may be run
-or skipped on alternating runs.
+Example DAG demonstrating the usage of BranchPythonOperator with depends_on_past=True, where tasks may be run or skipped on alternating runs.

Review comment:
       Revert this -- previous one was fine.

##########
File path: airflow/configuration.py
##########
@@ -53,9 +53,8 @@
 
 def expand_env_var(env_var):
     """
-    Expands (potentially nested) env vars by repeatedly applying
-    `expandvars` and `expanduser` until interpolation stops having
-    any effect.
+    Expands (potentially nested) env vars by repeatedly applying `expandvars` and `expanduser` until interpolation stops having any effect.
+

Review comment:
       The previous version was fine as it was.

##########
File path: airflow/configuration.py
##########
@@ -986,6 +985,8 @@ def get_custom_secret_backend() -> Optional[BaseSecretsBackend]:
 
 def initialize_secrets_backends() -> List[BaseSecretsBackend]:
     """
+    initialize_secrets_backends

Review comment:
       ```suggestion
       Initialize configured and built-in secrets backends 
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -88,6 +100,8 @@ def dag_ids(self):
     @abstractmethod
     def get_dag(self, dag_id):
         """
+        get_dag.
+
         :return: whether the task exists in this bag

Review comment:
       ```suggestion
           Get a DAG from this bag, if it exists, or else return None.
   
   ```

##########
File path: airflow/cli/commands/webserver_command.py
##########
@@ -46,6 +46,8 @@
 
 class GunicornMonitor(LoggingMixin):
     """
+    GunicornMonitor
+

Review comment:
       ```suggestion
   ```
   The existing first paragraph _was_ a good summary.

##########
File path: airflow/dag/base_dag.py
##########
@@ -48,6 +52,8 @@ def task_ids(self):
     @abstractmethod
     def full_filepath(self):
         """
+        full_filepath.
+
         :return: The absolute path to the file that contains this DAG's definition

Review comment:
       ```suggestion
           The absolute path to the file that contains this DAG's definition
   
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -57,6 +63,8 @@ def full_filepath(self):
     @abstractmethod
     def concurrency(self):
         """
+        concurrency.
+
         :return: maximum number of tasks that can run simultaneously from this DAG

Review comment:
       ```suggestion
           Maximum number of tasks that can run simultaneously from this DAG
   
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -65,6 +73,8 @@ def concurrency(self):
     @abstractmethod
     def pickle_id(self):
         """
+        pickle_id.
+
         :return: The pickle ID for this DAG, if it has one. Otherwise None.

Review comment:
       ```suggestion
           The pickle ID for this DAG, if it has one, otherwise None.
   
   ```

##########
File path: airflow/example_dags/example_external_task_marker_dag.py
##########
@@ -17,8 +17,7 @@
 # under the License.
 
 """
-Example DAG demonstrating setting up inter-DAG dependencies using ExternalTaskSensor and
-ExternalTaskMarker
+Example DAG demonstrating setting up inter-DAG dependencies using ExternalTaskSensor and ExternalTaskMarker

Review comment:
       ```suggestion
   Example DAG demonstrating setting up inter-DAG dependencies using ExternalTaskSensor and ExternalTaskMarker.
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -80,6 +90,8 @@ class BaseDagBag:
     @abstractmethod
     def dag_ids(self):
         """
+        dag_ids.
+
         :return: a list of DAG IDs in this bag

Review comment:
       ```suggestion
           A list of DAG IDs in this bag
   
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -39,6 +41,8 @@ def dag_id(self):
     @abstractmethod
     def task_ids(self):
         """
+        task_ids.
+
         :return: A list of task IDs that are in this DAG

Review comment:
       ```suggestion
           A list of task IDs that are in this DAG
   
   ```

##########
File path: airflow/contrib/operators/file_to_gcs.py
##########
@@ -31,7 +31,8 @@
 
 class FileToGoogleCloudStorageOperator(LocalFilesystemToGCSOperator):
     """
-    This class is deprecated.
+    This class is deprecated

Review comment:
       ```suggestion
       This class is deprecated.
   ```

##########
File path: airflow/dag/base_dag.py
##########
@@ -30,6 +30,8 @@ class BaseDag(metaclass=ABCMeta):
     @abstractmethod
     def dag_id(self):
         """
+        dag_id.
+
         :return: the DAG ID

Review comment:
       ```suggestion
           The DAG ID
   
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] mik-laj commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
mik-laj commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r514319677



##########
File path: airflow/models/dag.py
##########
@@ -388,6 +390,8 @@ def __exit__(self, _type, _value, _tb):
     @staticmethod
     def _upgrade_outdated_dag_access_control(access_control=None):
         """
+        _upgrade_outdated_dag_access_control

Review comment:
       It looks unreleated




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511460824



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -89,9 +92,9 @@ def execute(self, **kwargs):  # noqa: D403
 
 class SlackAPIPostOperator(SlackAPIOperator):
     """
-    Posts messages to a slack channel
-    Examples:
+    Posts messages to a slack channel.
 
+    Examples:
     .. code-block:: python

Review comment:
       Tests is failing because of this, a space is needed here
   
   ```suggestion
       Examples:
   
       .. code-block:: python
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-787558842


   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511483765



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -89,9 +92,9 @@ def execute(self, **kwargs):  # noqa: D403
 
 class SlackAPIPostOperator(SlackAPIOperator):
     """
-    Posts messages to a slack channel
-    Examples:
+    Posts messages to a slack channel.
 
+    Examples:
     .. code-block:: python

Review comment:
       @kaxil 
   I merged this suggestion and run pre-commit.
   
   I found that this suggestion is illegal about D412(No blank lines allowed between a section header and its content)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-714401746






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-711118734


   Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
   Here are some useful points:
   - Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
   - In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
   - Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
   - Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
   - Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
   - Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
   Apache Airflow is a community-driven project and together we are making it better πŸš€.
   In case of doubts contact the developers at:
   Mailing List: dev@airflow.apache.org
   Slack: https://s.apache.org/airflow-slack
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-721445384


   Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
   
   It will help if your squash your commits into single commit first so that there are less conflicts.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-718814623


   > parametrize
   
   Fixed spelling and pushed


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] ktrueda commented on a change in pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
ktrueda commented on a change in pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#discussion_r511485962



##########
File path: airflow/providers/slack/operators/slack.py
##########
@@ -89,9 +92,9 @@ def execute(self, **kwargs):  # noqa: D403
 
 class SlackAPIPostOperator(SlackAPIOperator):
     """
-    Posts messages to a slack channel
-    Examples:
+    Posts messages to a slack channel.
 
+    Examples:
     .. code-block:: python

Review comment:
       So I think that 
   if I obey D412, I can't pass the static check,
   if i pass the static check, I can't obey D412 (not confirmed.)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] removed a comment on pull request #11627: Add D205 pydocstyle check

Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #11627:
URL: https://github.com/apache/airflow/pull/11627#issuecomment-715450709






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org