You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/01/28 15:11:33 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request #1696: Alamb/move more code
alamb opened a new pull request #1696:
URL: https://github.com/apache/arrow-datafusion/pull/1696
# Which issue does this PR close?
re https://github.com/apache/arrow-datafusion/issues/743
Follow on to https://github.com/apache/arrow-datafusion/pull/1684
Built on the great work of @matthewmturner and @hntd187
# Rationale for this change
There are a bunch of tests in execution/context.rs that are not related to `ExecutionContext` (they are end to end tests for sql that happen to use the functions in `ExecutionContext`)
This both slows down compile times in the `datafusion` crate as well as makes it harder to discover existing test coverage.
This was annoying me recently when working in the `context` module so I decided to start moving the code over incrementally
# What changes are included in this PR?
I broke this PR into three commits for easier review.
1. The first 2 cut/paste the code from context.rs to various places in `datafusion/tests/sql`
2. The third then updates the tests to get them to run in their new home
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #1696: Move timestamp related tests out of context.rs and into sql integration test
Posted by GitBox <gi...@apache.org>.
alamb merged pull request #1696:
URL: https://github.com/apache/arrow-datafusion/pull/1696
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org