You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "paul cannon (JIRA)" <ji...@apache.org> on 2012/08/04 00:42:02 UTC
[jira] [Created] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
paul cannon created CASSANDRA-4488:
--------------------------------------
Summary: update cqlsh recognized syntax (for tab completion, etc)
Key: CASSANDRA-4488
URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
Project: Cassandra
Issue Type: Improvement
Components: Tools
Reporter: paul cannon
Assignee: paul cannon
Priority: Minor
Fix For: 1.1.4, 1.2
cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
* CASSANDRA-4179 (row key and column value composites; 1.2 only)
* CASSANDRA-3647 (sets/lists/maps; 1.2 only)
* CASSANDRA-4018 (inet type; 1.2 only)
* CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
* CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brandon Williams updated CASSANDRA-4488:
----------------------------------------
Reviewer: brandon.williams (was: iamaleksey)
Assignee: Aleksey Yeschenko (was: paul cannon)
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt, 4488.patch-v2.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464030#comment-13464030 ]
Jonathan Ellis commented on CASSANDRA-4488:
-------------------------------------------
Can you elaborate on what you have in mind here? To pick the first two as examples, I don't see what tab completion needs to deal with composite row keys or collections.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 1.1.6
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Comment Edited] (CASSANDRA-4488) update cqlsh recognized
syntax (for tab completion, etc)
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471246#comment-13471246 ]
Aleksey Yeschenko edited comment on CASSANDRA-4488 at 10/7/12 1:59 PM:
-----------------------------------------------------------------------
Attached version 2 (fixes indentation bug in print_recreate_keyspace, accomodates CASSANDRA-4423 and excludes the tests).
The patch is for trunk only. All the tests from this patch will be added in CASSANDRA-3920.
was (Author: iamaleksey):
Attached version 2 (fixes indentation bug in print_recreate_keyspace, accomodates #4423 and excludes the tests).
The patch is for trunk only. All the tests from this patch will be added in #3920.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt, 4488.patch-v2.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4488:
--------------------------------------
Assignee: paul cannon (was: Aleksey Yeschenko)
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Fix For: 1.1.6
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "paul cannon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464090#comment-13464090 ]
paul cannon commented on CASSANDRA-4488:
----------------------------------------
The machinery needs to be able to parse an entire line up to the completion point, or it has no way of knowing what the context is. Since many people have reported cqlsh's context-sensitive completion of things like columnfamily properties and possible values as useful, cqlsh needs to be able to recognize that map literals are valid property values, etc. Cqlsh also needs to know that composite row keys are possible or it wouldn't be able to figure out when a CREATE TABLE statement's column definitions were done and when the options are supposed to come.
>From a different direction, cqlsh is supposed to be able to DESCRIBE keyspaces and tables using current, valid syntax. People complain and write bug reports when they copy and paste DESCRIBE output and they get an error. So, the DESCRIBE machinery also needs to know how to show options in the map format and when to use the old syntax instead.
I have a pretty huge patch toward this end already, which not only allows parsing the new syntax, but also recognizes when it should be used versus the old syntax (3.0.0-beta1 for cassandra-1.1 servers), updates cqlsh's idea of what properties are valid and how they look ('compaction' as a map for 1.2 vs 'compaction_strategy_options' as a prefix for 1.1, etc), updates DESCRIBE KEYSPACE and DESCRIBE TABLE, adds hints to INSERT and UPDATE statements to let the user know what type is expected in a particular value position, and starts using schema_columnfamilies to get the list of available column names in certain cases since thrift doesn't report all of them anymore.
The only thing I have left to add there is the GRANT and REVOKE statements from CASSANDRA-4490, which should be pretty straightforward. I can attach what I have so far if you'd rather have Aleksey finish it off.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Fix For: 1.1.6
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471246#comment-13471246 ]
Aleksey Yeschenko commented on CASSANDRA-4488:
----------------------------------------------
Attached version 2 (fixes indentation bug in print_recreate_keyspace, accomodates #4423 and excludes the tests).
The patch is for trunk only. All the tests from this patch will be added in #3920.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt, 4488.patch-v2.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4488:
-----------------------------------------
Attachment: 4488.patch-v2.txt
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt, 4488.patch-v2.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Aleksey Yeschenko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aleksey Yeschenko updated CASSANDRA-4488:
-----------------------------------------
Fix Version/s: (was: 1.1.6)
1.2.0 beta 2
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-4488:
--------------------------------------
Reviewer: iamaleksey
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.1.6
>
> Attachments: 4488.patch.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "paul cannon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
paul cannon updated CASSANDRA-4488:
-----------------------------------
Attachment: 4488.patch.txt
There we go. The patch really applies on top of the patch from CASSANDRA-3920, since it adds to the tests, but if you want to commit this first you can just snip out the tests part until later.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Fix For: 1.1.6
>
> Attachments: 4488.patch.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13464139#comment-13464139 ]
Jonathan Ellis commented on CASSANDRA-4488:
-------------------------------------------
We will wait, then. :)
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Fix For: 1.1.6
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "Brandon Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13471615#comment-13471615 ]
Brandon Williams commented on CASSANDRA-4488:
---------------------------------------------
I feel like we shouldn't be punting in delete_memberbracket_completer since we should be able to determine what our possibilities are there.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: Aleksey Yeschenko
> Priority: Minor
> Labels: cql3, cqlsh
> Fix For: 1.2.0 beta 2
>
> Attachments: 4488.patch.txt, 4488.patch-v2.txt
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-4488) update cqlsh recognized syntax
(for tab completion, etc)
Posted by "paul cannon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-4488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13449242#comment-13449242 ]
paul cannon commented on CASSANDRA-4488:
----------------------------------------
Also CASSANDRA-4497 and CASSANDRA-4490, if it gets in.
> update cqlsh recognized syntax (for tab completion, etc)
> --------------------------------------------------------
>
> Key: CASSANDRA-4488
> URL: https://issues.apache.org/jira/browse/CASSANDRA-4488
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Reporter: paul cannon
> Assignee: paul cannon
> Priority: Minor
> Fix For: 1.1.6
>
>
> cqlsh syntax awareness (tab completion, etc) should be aware of several recent changes to CQL:
> * CASSANDRA-4179 (row key and column value composites; 1.2 only)
> * CASSANDRA-3647 (sets/lists/maps; 1.2 only)
> * CASSANDRA-4018 (inet type; 1.2 only)
> * CASSANDRA-4278 (hyphens in keyspace properties; 1.1 and up)
> * CASSANDRA-4217 (accessing ttl, timestamp; 1.1 and up)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira