You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Steve Huston (JIRA)" <qp...@incubator.apache.org> on 2008/10/07 22:38:44 UTC
[jira] Created: (QPID-1325) Make Address/TcpAddress manipulation
portable; extend SystemInfo functions to Windows
Make Address/TcpAddress manipulation portable; extend SystemInfo functions to Windows
-------------------------------------------------------------------------------------
Key: QPID-1325
URL: https://issues.apache.org/jira/browse/QPID-1325
Project: Qpid
Issue Type: Improvement
Components: C++ Broker, C++ Client
Reporter: Steve Huston
Assignee: Steve Huston
Priority: Minor
Attachments: address_sysinfo.diff
The C++ code for getting host name/address for a Url object is specific to Linux - this patch abstracts the behavior portably and extends to Windows. Does this by:
- Moving the Address and TcpAddress structs from qpid/Url.h to a new file, qpid/Address.h
- Extend SystemInfo functions to be able to get local host name and IP addresses using TcpAddress; old ioctl()-based Linux/posix code from qpid/Url.cpp is now in qpid/sys/posix/SystemInfo.cpp. There's also a new qpid/sys/windows/SystemInfo.cpp.
- In qpid/Url.cpp use the new SystemInfo::getLocalIpAddresses function instead of ioctl(); extends support to Windows
- SystemInfo.h has new methods added; also changed from a class with static methods to a namespace with functions to more closely reflect what it is - there's no data, just functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1325) Make Address/TcpAddress manipulation
portable; extend SystemInfo functions to Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1325:
-------------------------------
Attachment: address_sysinfo.diff
Patch.
Please review and advise. These changes are building and running correctly on RHEL 4.
> Make Address/TcpAddress manipulation portable; extend SystemInfo functions to Windows
> -------------------------------------------------------------------------------------
>
> Key: QPID-1325
> URL: https://issues.apache.org/jira/browse/QPID-1325
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Attachments: address_sysinfo.diff
>
>
> The C++ code for getting host name/address for a Url object is specific to Linux - this patch abstracts the behavior portably and extends to Windows. Does this by:
> - Moving the Address and TcpAddress structs from qpid/Url.h to a new file, qpid/Address.h
> - Extend SystemInfo functions to be able to get local host name and IP addresses using TcpAddress; old ioctl()-based Linux/posix code from qpid/Url.cpp is now in qpid/sys/posix/SystemInfo.cpp. There's also a new qpid/sys/windows/SystemInfo.cpp.
> - In qpid/Url.cpp use the new SystemInfo::getLocalIpAddresses function instead of ioctl(); extends support to Windows
> - SystemInfo.h has new methods added; also changed from a class with static methods to a namespace with functions to more closely reflect what it is - there's no data, just functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (QPID-1325) Make Address/TcpAddress manipulation
portable; extend SystemInfo functions to Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston updated QPID-1325:
-------------------------------
Attachment: system.diff
Another update which makes use of the new SystemInfo::getSystemId() method in qpid/broker/System.cpp.
> Make Address/TcpAddress manipulation portable; extend SystemInfo functions to Windows
> -------------------------------------------------------------------------------------
>
> Key: QPID-1325
> URL: https://issues.apache.org/jira/browse/QPID-1325
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Attachments: address_sysinfo.diff, system.diff
>
>
> The C++ code for getting host name/address for a Url object is specific to Linux - this patch abstracts the behavior portably and extends to Windows. Does this by:
> - Moving the Address and TcpAddress structs from qpid/Url.h to a new file, qpid/Address.h
> - Extend SystemInfo functions to be able to get local host name and IP addresses using TcpAddress; old ioctl()-based Linux/posix code from qpid/Url.cpp is now in qpid/sys/posix/SystemInfo.cpp. There's also a new qpid/sys/windows/SystemInfo.cpp.
> - In qpid/Url.cpp use the new SystemInfo::getLocalIpAddresses function instead of ioctl(); extends support to Windows
> - SystemInfo.h has new methods added; also changed from a class with static methods to a namespace with functions to more closely reflect what it is - there's no data, just functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (QPID-1325) Make Address/TcpAddress manipulation
portable; extend SystemInfo functions to Windows
Posted by "Steve Huston (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-1325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Steve Huston resolved QPID-1325.
--------------------------------
Resolution: Fixed
Fix Version/s: M4
At the risk of needing to go back and revise something later, I've committed these changes; svn revision 703179. They are building and running correctly on RHEL 4, and I need to continue making progress on the Windows changes to give adequate time to integrate and test for M4 freeze.
> Make Address/TcpAddress manipulation portable; extend SystemInfo functions to Windows
> -------------------------------------------------------------------------------------
>
> Key: QPID-1325
> URL: https://issues.apache.org/jira/browse/QPID-1325
> Project: Qpid
> Issue Type: Improvement
> Components: C++ Broker, C++ Client
> Reporter: Steve Huston
> Assignee: Steve Huston
> Priority: Minor
> Fix For: M4
>
> Attachments: address_sysinfo.diff, system.diff
>
>
> The C++ code for getting host name/address for a Url object is specific to Linux - this patch abstracts the behavior portably and extends to Windows. Does this by:
> - Moving the Address and TcpAddress structs from qpid/Url.h to a new file, qpid/Address.h
> - Extend SystemInfo functions to be able to get local host name and IP addresses using TcpAddress; old ioctl()-based Linux/posix code from qpid/Url.cpp is now in qpid/sys/posix/SystemInfo.cpp. There's also a new qpid/sys/windows/SystemInfo.cpp.
> - In qpid/Url.cpp use the new SystemInfo::getLocalIpAddresses function instead of ioctl(); extends support to Windows
> - SystemInfo.h has new methods added; also changed from a class with static methods to a namespace with functions to more closely reflect what it is - there's no data, just functions.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.