You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/03/08 05:12:28 UTC

[GitHub] [apisix] zaunist opened a new issue #6541: chore: As a Developer, I want to uniform code specification and style

zaunist opened a new issue #6541:
URL: https://github.com/apache/apisix/issues/6541


   ### Issue description
   
   ref this comment https://github.com/apache/apisix/pull/6509#discussion_r820630797
   
   when we write a code block like this:
   
   ```
   return res, nil
   ```
   
   The `, nil` is nonsense here, and the lua code style requires simplicity. So we should have to check our repository, remove the redundant `, nil` and unify the code style.
   
   You could refer to this document: https://github.com/apache/apisix/blob/master/CODE_STYLE.md
   
   Or do other people have any other comments?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander commented on issue #6541: chore: As a Developer, I want to uniform code specification and style

Posted by GitBox <gi...@apache.org>.

spacewander commented on issue #6541:
URL: https://github.com/apache/apisix/issues/6541#issuecomment-1061431473


   Please don't waste time doing this without any linter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix] spacewander closed issue #6541: chore: As a Developer, I want to uniform code specification and style

Posted by GitBox <gi...@apache.org>.

spacewander closed issue #6541:
URL: https://github.com/apache/apisix/issues/6541


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org