You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by eb...@apache.org on 2017/01/20 20:26:45 UTC
svn commit: r1779674 - /tomcat/native/trunk/native/configure.in
Author: ebourg
Date: Fri Jan 20 20:26:45 2017
New Revision: 1779674
URL: http://svn.apache.org/viewvc?rev=1779674&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60388
Ensure --disable-maintainer-mode doesn't enable the maintainer mode
Modified:
tomcat/native/trunk/native/configure.in
Modified: tomcat/native/trunk/native/configure.in
URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1779674&r1=1779673&r2=1779674&view=diff
==============================================================================
--- tomcat/native/trunk/native/configure.in (original)
+++ tomcat/native/trunk/native/configure.in Fri Jan 20 20:26:45 2017
@@ -198,12 +198,16 @@ AC_ARG_ENABLE(
maintainer-mode,
[ --enable-maintainer-mode Turn on debugging and compile time warnings],
[
- if test "$GCC" = "yes"; then
- CFLAGS="${CFLAGS} -DDEBUG -Wall"
- else
- CFLAGS="${CFLAGS} -DDEBUG"
- fi
-AC_MSG_RESULT([...Enabling Maintainer mode...])
+ case "${enableval}" in
+ yes )
+ if test "$GCC" = "yes"; then
+ CFLAGS="${CFLAGS} -DDEBUG -Wall"
+ else
+ CFLAGS="${CFLAGS} -DDEBUG"
+ fi
+ AC_MSG_RESULT([...Enabling Maintainer mode...])
+ ;;
+ esac
])
dnl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in
Posted by Emmanuel Bourg <eb...@apache.org>.
Le 24/01/2017 � 12:12, Konstantin Kolinko a �crit :
> There is a bug number for this change, 60388. It is better to mention
> it as <bug>60388</bug>:
Thanks I didn't notice the syntax to specify a bug number. I added it.
> The code and use of ${enableval} is OK. I mean the help string that
> accompanies this option.
>
> In other cases the help is formatted with AS_HELP_STRING() . In this
> case it is just plain text formatted with sequences of whitespace
> characters.
Good point, I added the AS_HELP_STRING macro for the maintainer-mode option.
> Thanks. But you did not run Apache Ant (that performs XSLT and
> generates the files in /docs directory).
>
> Once you run it and commit the changed /docs/whoweare.html file, in
> a few minutes it will be visible on the live site:
>
> http://tomcat.apache.org/whoweare.html
Ok I'll look into that.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in
Posted by Konstantin Kolinko <kn...@gmail.com>.
2017-01-23 11:38 GMT+03:00 Emmanuel Bourg <eb...@apache.org>:
> Hi Konstantin,
>
> Le 21/01/2017 à 08:58, Konstantin Kolinko a écrit :
>
>> 1. Please update xdocs/miscellaneous/changelog.xml as well.
>
> Thanks I didn't see it.
There is a bug number for this change, 60388. It is better to mention
it as <bug>60388</bug>:
>> 2. I see that other "able-" flags use AS_HELP_STRING() macro to format
>> help string.
>>
>> Maybe use it here as well?
>
> I got a look and they seem fine since they already use ${enableval}.
The code and use of ${enableval} is OK. I mean the help string that
accompanies this option.
In other cases the help is formatted with AS_HELP_STRING() . In this
case it is just plain text formatted with sequences of whitespace
characters.
>> 3. Don't forget to add youself to the list at Tomcat site
>> http://tomcat.apache.org/whoweare.html
>>
>> See README.txt in the site source directory,
>> https://svn.apache.org/repos/asf/tomcat/site/trunk/
>
> Done.
Thanks. But you did not run Apache Ant (that performs XSLT and
generates the files in /docs directory).
Once you run it and commit the changed /docs/whoweare.html file, in
a few minutes it will be visible on the live site:
http://tomcat.apache.org/whoweare.html
(You may need to hit refresh / F5 key in your browser to see the changes).
Best regards,
Konstantin Kolinko
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in
Posted by Emmanuel Bourg <eb...@apache.org>.
Hi Konstantin,
Le 21/01/2017 � 08:58, Konstantin Kolinko a �crit :
> 1. Please update xdocs/miscellaneous/changelog.xml as well.
Thanks I didn't see it.
> 2. I see that other "able-" flags use AS_HELP_STRING() macro to format
> help string.
>
> Maybe use it here as well?
I got a look and they seem fine since they already use ${enableval}.
> 3. Don't forget to add youself to the list at Tomcat site
> http://tomcat.apache.org/whoweare.html
>
> See README.txt in the site source directory,
> https://svn.apache.org/repos/asf/tomcat/site/trunk/
Done.
Thank you for the review.
Emmanuel Bourg
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r1779674 - /tomcat/native/trunk/native/configure.in
Posted by Konstantin Kolinko <kn...@gmail.com>.
Hi! Welcome!
1. Please update xdocs/miscellaneous/changelog.xml as well.
2. I see that other "able-" flags use AS_HELP_STRING() macro to format
help string.
Maybe use it here as well?
3. Don't forget to add youself to the list at Tomcat site
http://tomcat.apache.org/whoweare.html
See README.txt in the site source directory,
https://svn.apache.org/repos/asf/tomcat/site/trunk/
Best regards,
Konstantin Kolinko
2017-01-20 23:26 GMT+03:00 <eb...@apache.org>:
> Author: ebourg
> Date: Fri Jan 20 20:26:45 2017
> New Revision: 1779674
>
> URL: http://svn.apache.org/viewvc?rev=1779674&view=rev
> Log:
> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=60388
> Ensure --disable-maintainer-mode doesn't enable the maintainer mode
>
> Modified:
> tomcat/native/trunk/native/configure.in
>
> Modified: tomcat/native/trunk/native/configure.in
> URL: http://svn.apache.org/viewvc/tomcat/native/trunk/native/configure.in?rev=1779674&r1=1779673&r2=1779674&view=diff
> ==============================================================================
> --- tomcat/native/trunk/native/configure.in (original)
> +++ tomcat/native/trunk/native/configure.in Fri Jan 20 20:26:45 2017
> @@ -198,12 +198,16 @@ AC_ARG_ENABLE(
> maintainer-mode,
> [ --enable-maintainer-mode Turn on debugging and compile time warnings],
> [
> - if test "$GCC" = "yes"; then
> - CFLAGS="${CFLAGS} -DDEBUG -Wall"
> - else
> - CFLAGS="${CFLAGS} -DDEBUG"
> - fi
> -AC_MSG_RESULT([...Enabling Maintainer mode...])
> + case "${enableval}" in
> + yes )
> + if test "$GCC" = "yes"; then
> + CFLAGS="${CFLAGS} -DDEBUG -Wall"
> + else
> + CFLAGS="${CFLAGS} -DDEBUG"
> + fi
> + AC_MSG_RESULT([...Enabling Maintainer mode...])
> + ;;
> + esac
> ])
>
> dnl
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
> For additional commands, e-mail: dev-help@tomcat.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org