You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/04/24 16:38:51 UTC

[GitHub] [incubator-tvm] michalpiszczek opened a new pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

michalpiszczek opened a new pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436


   Follow up to: https://github.com/apache/incubator-tvm/pull/5425
   
   Changes: 
   - Re-enables a test for remote execution with the TFLite runtime via RPC
   - The test for local execution is left skipped due to flakiness with reading the output tensor
   - The tests are made discoverable by pytest
   - Modifies the build steps for the CI CPU image to include dependencies needed by the TFLite runtime
   
   cc @tqchen @tmoreau89 @ZihengJiang


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-619150720


   @michalpiszczek one suggestion is just to leave the CI commented out, and scope this PR to just changing the dockerfile


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] michalpiszczek commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-619160168


   @tmoreau89 @tqchen I've created a separate PR with just the docker changes here: https://github.com/apache/incubator-tvm/pull/5437


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-619125877


   @michalpiszczek please PR the docker changes separately as we need to first build the docker binary and update them to the CI env.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] michalpiszczek commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621939200


   @tqchen I believe I've done that here: https://github.com/apache/incubator-tvm/pull/5436/commits/530ee65c96db562745561092dcec43e136acbaec . I followed the pattern from `test_cudnn.py`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tmoreau89 commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-620953773


   @tqchen has the Docker image from #5437 been generated and updated in Jenkins CI?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen merged pull request #5436: [TFLite Runtime] Fix bug and re-enable RPC execution test

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621962718


   Please check the ci error https://ci.tvm.ai/blue/organizations/jenkins/tvm/detail/PR-5436/4/pipeline seems was due to changes to the cpu build config file.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen edited a comment on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tqchen edited a comment on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621364933


   NOTE: 
   - the ci-cpu is still blocked by https://github.com/apache/incubator-tvm/issues/5455 
   - but ci-gpu is now updated to sync with the latest state. If we can update the testcase to pre-check the env before test, we should be able to cover the case already via ci-gpu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] tqchen commented on pull request #5436: [TFLite Runtime] Re-enable test for remote execution via RPC

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-621364933


   NOTE: the ci-cpu is still blocked by https://github.com/apache/incubator-tvm/issues/5455 ci-gpu is now updated. If we can update the testcase to pre-check the env before test, we should be able to cover the case already via ci-gpu


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-tvm] michalpiszczek commented on pull request #5436: [TFLite Runtime] Fix bug and re-enable RPC execution test

Posted by GitBox <gi...@apache.org>.
michalpiszczek commented on pull request #5436:
URL: https://github.com/apache/incubator-tvm/pull/5436#issuecomment-628945385


   @tmoreau89 @tqchen PTAL, now includes fix to keep alive the interpreter's backing buffer


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org