You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Andrey Yakushev (JIRA)" <ji...@apache.org> on 2007/03/19 16:26:32 UTC
[jira] Created: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
[drlvm][lang-management] MemoryMXBean native methods implementation
-------------------------------------------------------------------
Key: HARMONY-3427
URL: https://issues.apache.org/jira/browse/HARMONY-3427
Project: Harmony
Issue Type: New Feature
Components: DRLVM
Reporter: Andrey Yakushev
MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Andrey Yakushev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Yakushev updated HARMONY-3427:
-------------------------------------
Attachment: vm_MemoryMXBean.patch
This patch replaces a set of native method stubs for MemoryMXBean in DRLVM with real implementation.
After patch integration all Classlib lang-management tests related to this bean passed on Win2003 and Linux x86_64.
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Attachments: vm_MemoryMXBean.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3427.
----------------------------------------
Resolution: Fixed
2nd patch is applied at 529260. Please check that it fixes the bug.
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3427) [drlvm][kernel][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-3427:
---------------------------------------
Summary: [drlvm][kernel][lang-management] MemoryMXBean native methods implementation (was: [drlvm][lang-management] MemoryMXBean native methods implementation)
> [drlvm][kernel][lang-management] MemoryMXBean native methods implementation
> ---------------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3427) [drlvm][kernel][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3427.
----------------------------------------
Resolution: Fixed
Patch is applied at 559586. Please check that it was applied as expected.
> [drlvm][kernel][lang-management] MemoryMXBean native methods implementation
> ---------------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assignee: Gregory Shimansky
> Attachments: H3427.patch, vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Andrey Yakushev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Yakushev updated HARMONY-3427:
-------------------------------------
Patch Info: [Patch Available]
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Attachments: vm_MemoryMXBean.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Andrey Yakushev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Yakushev reopened HARMONY-3427:
--------------------------------------
Reopend because an additional patch should be applied
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-3427:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Andrey Yakushev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Yakushev updated HARMONY-3427:
-------------------------------------
Attachment: vm_MemoryMXBean_bug.patch
During verification I found invalid memory sizes on Linuxes.
vm_MemoryMXBean_bug.patch is this bug fix.
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reopened HARMONY-3427:
----------------------------------------
I agree that free should be done on all return paths. Also files opened with fopen need to be closed on all return paths. In addition I think it is necessary to check windows API functions whether they create resources such as handles that have to be closed.
This is the reason for reopening this issue.
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-3427) [drlvm][kernel][lang-management]
MemoryMXBean native methods implementation
Posted by "Andrey Yakushev (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrey Yakushev updated HARMONY-3427:
-------------------------------------
Attachment: H3427.patch
H3427.patch should eliminate memory leakage and close opened files on Linux.
IMO on Windows there is no such problems at all.
> [drlvm][kernel][lang-management] MemoryMXBean native methods implementation
> ---------------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assignee: Gregory Shimansky
> Attachments: H3427.patch, vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12489354 ]
Alexey Varlamov commented on HARMONY-3427:
------------------------------------------
Guys, a few leaks were introduced in vm/port/src/vmem/linux/port_vmem.c - quite a few returns w/o freeing buf.
Please fix - do I need to reopen this JIRA?
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-3427) [drlvm][kernel][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-3427.
--------------------------------------
No response, assuming ok.
> [drlvm][kernel][lang-management] MemoryMXBean native methods implementation
> ---------------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assignee: Gregory Shimansky
> Attachments: H3427.patch, vm_MemoryMXBean.patch, vm_MemoryMXBean_bug.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-3427) [drlvm][lang-management]
MemoryMXBean native methods implementation
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-3427.
----------------------------------------
Resolution: Fixed
Patch applied at 525155. Please check that it was applied as expected.
> [drlvm][lang-management] MemoryMXBean native methods implementation
> -------------------------------------------------------------------
>
> Key: HARMONY-3427
> URL: https://issues.apache.org/jira/browse/HARMONY-3427
> Project: Harmony
> Issue Type: New Feature
> Components: DRLVM
> Reporter: Andrey Yakushev
> Assigned To: Gregory Shimansky
> Attachments: vm_MemoryMXBean.patch
>
>
> MemoryMXBean stubs from HARMONY-1821 should be replaced with real implementation
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.