You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@aurora.apache.org by "Zameer Manji (JIRA)" <ji...@apache.org> on 2015/01/30 20:27:35 UTC
[jira] [Commented] (AURORA-184) Implicit scheduling constraints
should be removed
[ https://issues.apache.org/jira/browse/AURORA-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299097#comment-14299097 ]
Zameer Manji commented on AURORA-184:
-------------------------------------
Thanks to a patch from [~fpfeiffer] the implicit constraints for host and rack can be disabled.
{noformat}
commit db6a19994d7fc36b09aa1108d680f3418901d628
Author: Florian Pfeiffer <ap...@x8s.de>
Date: Fri Jan 30 11:24:37 2015 -0800
[AURORA-184] Remove hardcoded 'host' and 'rack' limit constraints
This is the first step for AURORA-184, that removes the default host&rack limit
constraints.
The second step that's still missing would be to add s.th. like
"--default-constraints" as start parameter to the scheduler.
AURORA-174 could probably be closed with this?(since the rack limit constraint
can be configured in the .aurora file)
I can't really estimate the effect of my changes in
StorageBackfillTest&SchedulerThriftInterfaceTest, please have a closer look at
the changes I did there.
Since this is also my first code submit, comments about codestyle&other bad
habbits are very appreciated.
Testing Done:
Added test for ConfigurationManager.hasName
Added test testNoHostAndRackConstraintsAdded, that checks if the constraints are
present
Tested on vagrant devcluster to see if constraints are also gone in "real life"
Bugs closed: AURORA-184
Reviewed at https://reviews.apache.org/r/30010/
.../configuration/ConfigurationManager.java | 58 ++++++++++++----------
.../configuration/ConfigurationManagerTest.java | 29 +++++++++++
2 files changed, 62 insertions(+), 25 deletions(-)
{noformat}
> Implicit scheduling constraints should be removed
> -------------------------------------------------
>
> Key: AURORA-184
> URL: https://issues.apache.org/jira/browse/AURORA-184
> Project: Aurora
> Issue Type: Story
> Components: Scheduler
> Reporter: Kevin Sweeney
> Assignee: Florian Pfeiffer
>
> Right now the scheduler hardcodes "host" and "rack" limit constraints into submitted jobs. These require slave attributes to be set on the slave command-line, which means deploying aurora on a running mesos cluster needs a hard slave restart (changing slave attributes invalidates recovery metadata, meaning underlying tasks must be killed). In addition, "host" and "rack" might not accurately capture failure domains in other mesos deployments.
> Make this constraint-set configurable at deploy-time, defaulting to empty.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)