You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/09/30 02:54:19 UTC
[GitHub] [apisix-dashboard] liuxiran opened a new issue #529: [Disscussion] improve the UE of config Authentication plugins
liuxiran opened a new issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirements
- [ ] Feature or performance improvement
- [ ] Other
___
### Why
The Authentication plugins, e.g: `basic-auth` `openid-connect` and other auth plugins supported by Apisix should work with consumer together. Only when one auth plugin is enabled and configed correctly can a consumer be created or modified, and can access a route which is also enabled the same auth plugin. At the same time, a route of a service can enabled the auth plugin without any configs(even if configured here, the auth plugin configuration of consumer will matched by default).
RIght now, the auth plugins can be configed both in consumer and route, but the auth config in route doesn't really work, and it will Induce user that only the configed consumer can access the route. So it would be better to improve the UE of config auth plugins.
### Proposal
1. the authentication plugins should be enabled with configuration.
1. the authentication plugins should be only shown with a switch to enabled/disabled.
1. right now if a route enabled two auth plugins, it should be matched with this two auth token, In fact, it is not possible for users to access the same route using two or more different authentication methods. so it would be better to only enabled one auth plugin in route (or ).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran closed issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran closed issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701298221
> Got your point, you mean for Auth plugins, we should only config it in Consumer instead of Route, and we COULD choose to enable or disable it in Route instead of cobfig, right?
>
> I agree to this proposal, how about others suggestions?
>
> cc @membphis @nic-chen @moonming ?
yes you got my point @juzhiyuan 🤝, and furthermore, if the authentication plugin can be turned into the consumer’s default support plugin, just like `proxy-rewrite` in route, that would be better, but the cost of plugin modification may be higher
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701309983
yep, let's implement your proposal first :D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735386888
I checked this issue once more, and it seems that the backend should support this feature too 🤔 @liuxiran @membphis right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735603507
This solution works for me, but it seems that there still has also a lot of work to do, could you please take a look at this issue? cc @membphis @tokers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735681671
> We can create a new API to return all the information of the plug-in, such as `schema`, `type`, `priority`, etc.
>
> For example the new API: `/apisix/admin/plugins/meta_attributes`, we need to discuss it on the mailing list first.
>
> @liuxiran would like to handle this job?
sure, I have already sent a mail to dev, just waiting for others' comments and suggestions :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735641857
We can create a new API to return all the information of the plug-in, such as `schema`, `type`, `priority`, etc.
For example the new API: `/apisix/admin/plugins/meta_attributes`, we need to discuss it on the mailing list first.
@liuxiran would like to handle this job?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701310124
I just put this feature in M1.7.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran edited a comment on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735574726
> I checked this issue once more, and it seems that the backend should support this feature too @liuxiran @membphis right?
thanks for @juzhiyuan 's reminder, I also rethinked this issue, and IMHO, it is better to get support from BE:
- get `whether the plugin needs to be config` together with `category` of all plugins instead of only get plugin names from `GET /apisix/admin/plugins`
`whether the plugin needs to be config` could also not be a specific flag, FE can also judge from whether the [plugin].schema.properties is empty, in this case , api should return the schema at the same time.
This would also apply to other plugins that do not require configuration :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-748453580
any update?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-740524775
> @liuxiran I think we can close this issue and create a new one with the final conclusion from the emailing list.
got it , and as we talked yesterday., this issue would be move to M2.3, right? @membphis
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-740688289
yes, confirm this @liuxiran
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-740496021
@liuxiran I think we can close this issue and create a new one with the final conclusion from the emailing list.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701146798
Got your point, you mean for Auth plugins, we should only config it in Consumer instead of Route, and we COULD choose to enable or disable it in Route instead of cobfig, right?
I agree to this proposal, how about others suggestions?
cc @membphis @nic-chen @moonming ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
nic-chen commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701242135
agree +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
juzhiyuan commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-739651465
Hi folks, final conclusion here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701229844
agree with this proposal too.
https://github.com/apache/apisix/issues/2308 , if we support this feature, the dashboard will easier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-701129466
@juzhiyuan @LiteSun @bzp2010
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-749441143
after the new api `GET /plugins?all=ture` finished, I will open a new issue to trace the process. close it now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #529: discuss: improve the UE of config Authentication plugins
Posted by GitBox <gi...@apache.org>.
liuxiran commented on issue #529:
URL: https://github.com/apache/apisix-dashboard/issues/529#issuecomment-735574726
> I checked this issue once more, and it seems that the backend should support this feature too @liuxiran @membphis right?
thanks for @juzhiyuan 's reminder, I also rethinked this issue, and IMHO, it is better to get support from BE:
- get `whether the plugin needs to be config` together with `category` of all plugins instead of only get plugin names from `GET /apisix/admin/plugins`
`whether the plugin needs to be config` could also not be a specific flag, FE can also judge from whether the [plugin].schema.properties is empty, in this case , api should return the schema at the same time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org