You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by GitBox <gi...@apache.org> on 2022/01/27 13:54:21 UTC

[GitHub] [apr] monkburger opened a new pull request #32: Use MAP_POPULATE if available

monkburger opened a new pull request #32:
URL: https://github.com/apache/apr/pull/32


   mmap's MAP_POPULATE will help to avoid expensive page faults by filling the page table with entries (read ahead on a file) MAP_POPULATE has been present on Linux since kernel 2.5.46 (20 years ago). 
   
   XXX: Would it be better to scope configure.in to check to see if MAP_POPULATE returns EINVAL? 
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apr] monkburger closed pull request #32: Use MAP_POPULATE if available

Posted by GitBox <gi...@apache.org>.
monkburger closed pull request #32:
URL: https://github.com/apache/apr/pull/32


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [apr] ylavic commented on pull request #32: Use MAP_POPULATE if available

Posted by GitBox <gi...@apache.org>.
ylavic commented on pull request #32:
URL: https://github.com/apache/apr/pull/32#issuecomment-1023334211


   I'd suggest that you add a new `APR_MMAP_POPULATE` flag (e.g. `#define APR_MMAP_POPULATE 4` for a bitmask with the existing `APR_MMAP_READ` and `APR_MMAP_WRITE`) so that the user has the choice.
   
   Some may not want to pay the price of filling up the page table entries at mmap() time if they don't necessarily access the memory entirely later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org