You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "uros-b (via GitHub)" <gi...@apache.org> on 2026/08/05 09:54:54 UTC
[PR] API: Add tests for UnicodeUtil [iceberg]
uros-b opened a new pull request, #17528:
URL: https://github.com/apache/iceberg/pull/17528
`UnicodeUtil` had no dedicated test class. This adds one covering its public surface:
- `isCharHighSurrogate` at both ends of the high-surrogate range (0xD800-0xDBFF), plus a low surrogate and an ASCII char
- `truncateString` when no truncation is needed, when truncating by code points, and that a surrogate pair (emoji) is not split
- the `IllegalArgumentException` guard for a non-positive truncate length
- `truncateStringMin` / `truncateStringMax`, including the overflow case where every retained code point is the maximum and no greater bound exists (returns null)
Test-only; documents existing behavior.
---
**AI Disclosure**
- Model: Claude Opus 4.8
- Platform/Tool: Claude Code
- Human Oversight: fully reviewed
- Prompt Summary: Add unit tests documenting the existing behavior of a pure utility class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#discussion_r3720245157
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+public class TestUnicodeUtil {
+
+ @Test
+ public void testIsCharHighSurrogate() {
Review Comment:
Will need to avoid using test prefixes here and below
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#discussion_r3726876248
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+class TestUnicodeUtil {
+
+ @Test
+ void isCharHighSurrogate() {
+ // the high-surrogate range is 0xD800 - 0xDBFF
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate
+ // low surrogates and regular characters are not high surrogates
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse();
+ }
+
+ @Test
+ void truncateStringShorterThanLength() {
+ // no truncation is needed when the length is at least the number of characters
+ assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc");
+ assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringByCodePoints() {
+ assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc");
+ // a surrogate pair is a single unicode character and is not split
+ String withSurrogatePair = "a😀b"; // "a" + emoji + "b"
+ assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀");
+ }
+
+ @Test
+ void truncateStringRejectsNonPositiveLength() {
+ assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Truncate length should be positive");
+ }
+
+ @Test
+ void truncateStringMin() {
+ // the minimum is just the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc");
Review Comment:
what if the string is shorter than the lengh?
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+class TestUnicodeUtil {
+
+ @Test
+ void isCharHighSurrogate() {
+ // the high-surrogate range is 0xD800 - 0xDBFF
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate
+ // low surrogates and regular characters are not high surrogates
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse();
+ }
+
+ @Test
+ void truncateStringShorterThanLength() {
+ // no truncation is needed when the length is at least the number of characters
+ assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc");
+ assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringByCodePoints() {
+ assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc");
+ // a surrogate pair is a single unicode character and is not split
+ String withSurrogatePair = "a😀b"; // "a" + emoji + "b"
+ assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀");
+ }
+
+ @Test
+ void truncateStringRejectsNonPositiveLength() {
+ assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Truncate length should be positive");
+ }
+
+ @Test
+ void truncateStringMin() {
+ // the minimum is just the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringMax() {
+ // the maximum increments the last code point of the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMax("abcde", 3)).isEqualTo("abd");
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#discussion_r3735220773
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+class TestUnicodeUtil {
+
+ @Test
+ void isCharHighSurrogate() {
+ // the high-surrogate range is 0xD800 - 0xDBFF
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate
+ // low surrogates and regular characters are not high surrogates
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse();
+ }
+
+ @Test
+ void truncateStringShorterThanLength() {
+ // no truncation is needed when the length is at least the number of characters
+ assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc");
+ assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringByCodePoints() {
+ assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc");
+ // a surrogate pair is a single unicode character and is not split
+ String withSurrogatePair = "a😀b"; // "a" + emoji + "b"
+ assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀");
+ }
+
+ @Test
+ void truncateStringRejectsNonPositiveLength() {
+ assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Truncate length should be positive");
+ }
+
+ @Test
+ void truncateStringMin() {
+ // the minimum is just the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc");
Review Comment:
Done, thank you!
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+class TestUnicodeUtil {
+
+ @Test
+ void isCharHighSurrogate() {
+ // the high-surrogate range is 0xD800 - 0xDBFF
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate
+ // low surrogates and regular characters are not high surrogates
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse();
+ }
+
+ @Test
+ void truncateStringShorterThanLength() {
+ // no truncation is needed when the length is at least the number of characters
+ assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc");
+ assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringByCodePoints() {
+ assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc");
+ // a surrogate pair is a single unicode character and is not split
+ String withSurrogatePair = "a😀b"; // "a" + emoji + "b"
+ assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀");
+ }
+
+ @Test
+ void truncateStringRejectsNonPositiveLength() {
+ assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Truncate length should be positive");
+ }
+
+ @Test
+ void truncateStringMin() {
+ // the minimum is just the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringMax() {
+ // the maximum increments the last code point of the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMax("abcde", 3)).isEqualTo("abd");
Review Comment:
Tnx!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra merged PR #17528:
URL: https://github.com/apache/iceberg/pull/17528
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#discussion_r3726883066
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+class TestUnicodeUtil {
+
+ @Test
+ void isCharHighSurrogate() {
+ // the high-surrogate range is 0xD800 - 0xDBFF
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uD800')).isTrue(); // first high surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDBFF')).isTrue(); // last high surrogate
+ // low surrogates and regular characters are not high surrogates
+ assertThat(UnicodeUtil.isCharHighSurrogate('\uDC00')).isFalse(); // first low surrogate
+ assertThat(UnicodeUtil.isCharHighSurrogate('a')).isFalse();
+ }
+
+ @Test
+ void truncateStringShorterThanLength() {
+ // no truncation is needed when the length is at least the number of characters
+ assertThat(UnicodeUtil.truncateString("abc", 5)).isEqualTo("abc");
+ assertThat(UnicodeUtil.truncateString("abc", 3)).isEqualTo("abc");
+ }
+
+ @Test
+ void truncateStringByCodePoints() {
+ assertThat(UnicodeUtil.truncateString("abcde", 3)).isEqualTo("abc");
+ // a surrogate pair is a single unicode character and is not split
+ String withSurrogatePair = "a😀b"; // "a" + emoji + "b"
+ assertThat(UnicodeUtil.truncateString(withSurrogatePair, 2)).isEqualTo("a😀");
+ }
+
+ @Test
+ void truncateStringRejectsNonPositiveLength() {
+ assertThatThrownBy(() -> UnicodeUtil.truncateString("abc", 0))
+ .isInstanceOf(IllegalArgumentException.class)
+ .hasMessage("Truncate length should be positive");
+ }
+
+ @Test
+ void truncateStringMin() {
+ // the minimum is just the truncated prefix
+ assertThat(UnicodeUtil.truncateStringMin("abcde", 3)).isEqualTo("abc");
Review Comment:
can we test this with a shorter/longer/equal-length string and also include an empty string. Same for the truncateStringMax case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#issuecomment-5216068493
Thank you folks @szehon-ho @ebyhr @nastra!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#issuecomment-5225561711
This one should be ready to merge ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] API: Add tests for UnicodeUtil [iceberg]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on code in PR #17528:
URL: https://github.com/apache/iceberg/pull/17528#discussion_r3722224360
##########
api/src/test/java/org/apache/iceberg/util/TestUnicodeUtil.java:
##########
@@ -0,0 +1,82 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.iceberg.util;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import org.junit.jupiter.api.Test;
+
+public class TestUnicodeUtil {
+
+ @Test
+ public void testIsCharHighSurrogate() {
Review Comment:
Update: removed test prefixes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org